From c04d2595fc7ee609864a22e269e14cdbbff34615 Mon Sep 17 00:00:00 2001 From: ladyada Date: Mon, 14 Sep 2026 17:58:34 -0400 Subject: [PATCH 1/3] Use the configured I2C address when reading GPS data Co-authored-by: Limor Fried --- src/Adafruit_GPS.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Adafruit_GPS.cpp b/src/Adafruit_GPS.cpp index fd8086c..6c719a0 100644 --- a/src/Adafruit_GPS.cpp +++ b/src/Adafruit_GPS.cpp @@ -308,8 +308,8 @@ char Adafruit_GPS::read(void) { _buff_idx++; } else { // refill the buffer! - if (gpsI2C->requestFrom((uint8_t)0x10, (uint8_t)GPS_MAX_I2C_TRANSFER, - (uint8_t) true) == GPS_MAX_I2C_TRANSFER) { + if (gpsI2C->requestFrom(_i2caddr, (uint8_t)GPS_MAX_I2C_TRANSFER, + (uint8_t)true) == GPS_MAX_I2C_TRANSFER) { // got data! _buff_max = 0; char curr_char = 0; From 4c02b0035f84cd62dcec38290a2f0f7922d52611 Mon Sep 17 00:00:00 2001 From: "Limor \"Ladyada\" Fried" Date: Mon, 14 Sep 2026 20:22:54 -0400 Subject: [PATCH 2/3] Refactor I2C request call for GPS data Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --- src/Adafruit_GPS.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/Adafruit_GPS.cpp b/src/Adafruit_GPS.cpp index 6c719a0..99a88e4 100644 --- a/src/Adafruit_GPS.cpp +++ b/src/Adafruit_GPS.cpp @@ -308,8 +308,9 @@ char Adafruit_GPS::read(void) { _buff_idx++; } else { // refill the buffer! - if (gpsI2C->requestFrom(_i2caddr, (uint8_t)GPS_MAX_I2C_TRANSFER, - (uint8_t)true) == GPS_MAX_I2C_TRANSFER) { + if (gpsI2C->requestFrom((uint8_t)_i2caddr, + (uint8_t)GPS_MAX_I2C_TRANSFER, + true) == GPS_MAX_I2C_TRANSFER) { // got data! _buff_max = 0; char curr_char = 0; From 21384bf55461523a6038def699f8685722658321 Mon Sep 17 00:00:00 2001 From: ladyada Date: Mon, 14 Sep 2026 20:42:46 -0400 Subject: [PATCH 3/3] Match CI formatting for the GPS I2C read call Co-authored-by: Limor Fried --- src/Adafruit_GPS.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/Adafruit_GPS.cpp b/src/Adafruit_GPS.cpp index 99a88e4..7193229 100644 --- a/src/Adafruit_GPS.cpp +++ b/src/Adafruit_GPS.cpp @@ -308,8 +308,7 @@ char Adafruit_GPS::read(void) { _buff_idx++; } else { // refill the buffer! - if (gpsI2C->requestFrom((uint8_t)_i2caddr, - (uint8_t)GPS_MAX_I2C_TRANSFER, + if (gpsI2C->requestFrom((uint8_t)_i2caddr, (uint8_t)GPS_MAX_I2C_TRANSFER, true) == GPS_MAX_I2C_TRANSFER) { // got data! _buff_max = 0;