From 074cfcfbbbeb1f2459c29a64bbecf65cd4e5b8a4 Mon Sep 17 00:00:00 2001 From: Ton Huisman Date: Fri, 14 Jan 2022 15:43:22 +0100 Subject: [PATCH 1/2] [Build] Set LIMIT_BUILD_SIZE also for ESP32 on DISPLAY builds (and pre-IDF4.x) to fix build-size issue --- src/src/CustomBuild/define_plugin_sets.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/src/CustomBuild/define_plugin_sets.h b/src/src/CustomBuild/define_plugin_sets.h index 539722dfa..857f481b2 100644 --- a/src/src/CustomBuild/define_plugin_sets.h +++ b/src/src/CustomBuild/define_plugin_sets.h @@ -1221,8 +1221,8 @@ To create/register a plugin, you have to : // Collection of all display plugins. (also NeoPixel) #ifdef PLUGIN_DISPLAY_COLLECTION - #if !defined(LIMIT_BUILD_SIZE) && defined(ESP8266) - #define LIMIT_BUILD_SIZE // Redice buildsize on ESP8266 to fit in all Display plugins + #if !defined(LIMIT_BUILD_SIZE) && (defined(ESP8266) || ESP_IDF_VERSION_MAJOR < 4) + #define LIMIT_BUILD_SIZE // Reduce buildsize (on ESP8266 / pre-IDF4.x) to fit in all Display plugins #endif #ifndef USES_P012 #define USES_P012 // LCD From 91e8d34b8b43bd6b2cc1cb6e8250ad3d7cf2f7cf Mon Sep 17 00:00:00 2001 From: Ton Huisman Date: Fri, 14 Jan 2022 15:58:37 +0100 Subject: [PATCH 2/2] [Build] Enhanced condition --- src/src/CustomBuild/define_plugin_sets.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/src/CustomBuild/define_plugin_sets.h b/src/src/CustomBuild/define_plugin_sets.h index 857f481b2..403d2157f 100644 --- a/src/src/CustomBuild/define_plugin_sets.h +++ b/src/src/CustomBuild/define_plugin_sets.h @@ -1221,7 +1221,7 @@ To create/register a plugin, you have to : // Collection of all display plugins. (also NeoPixel) #ifdef PLUGIN_DISPLAY_COLLECTION - #if !defined(LIMIT_BUILD_SIZE) && (defined(ESP8266) || ESP_IDF_VERSION_MAJOR < 4) + #if !defined(LIMIT_BUILD_SIZE) && (defined(ESP8266) || !(ESP_IDF_VERSION_MAJOR > 3)) #define LIMIT_BUILD_SIZE // Reduce buildsize (on ESP8266 / pre-IDF4.x) to fit in all Display plugins #endif #ifndef USES_P012