From a513c8d631fc66f6e5cffd5d40dd93a835c89edc Mon Sep 17 00:00:00 2001 From: Aleksandr Zharov Date: Sat, 24 Oct 2026 22:02:13 +0500 Subject: [PATCH] [Settings] Fix clearTask() overwriting pins of other tasks OLD_TaskDeviceID only has N_TASKS - 9 elements, but clearTask() still wrote OLD_TaskDeviceID[task]. For task index 3 and up this writes past the array into TaskDevicePin1..3/TaskDevicePort of other tasks. The array is unused, so the write is removed. Co-Authored-By: Claude Opus 5.5 --- src/src/DataStructs_templ/SettingsStruct.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/src/src/DataStructs_templ/SettingsStruct.cpp b/src/src/DataStructs_templ/SettingsStruct.cpp index 040986039..ded28e1ff 100644 --- a/src/src/DataStructs_templ/SettingsStruct.cpp +++ b/src/src/DataStructs_templ/SettingsStruct.cpp @@ -793,7 +793,6 @@ void SettingsStruct_tmpl::clearTask(taskIndex_t task) { TaskDeviceSendData[i][task] = false; } TaskDeviceNumber[task] = 0u; //.setInvalid(); - OLD_TaskDeviceID[task] = 0u; // UNUSED: this can be removed TaskDevicePin1[task] = -1; TaskDevicePin2[task] = -1; TaskDevicePin3[task] = -1;