From 0dabd89ef2e712ba89e2f284b3ba3d5aee1deca8 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 31 Dec 2025 20:39:12 +0000 Subject: [PATCH] Address code review feedback - add clarifying comments - Add comment explaining TEST_STATUS outcome values - Improve error message specificity in generateMarkdownSummary.js Co-authored-by: thomasnordquist <7721625+thomasnordquist@users.noreply.github.com> --- .github/workflows/tests.yml | 1 + scripts/generateMarkdownSummary.js | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index aaf8b607..60bd7d95 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -150,6 +150,7 @@ jobs: id: markdown env: BASE_URL: ${{ steps.fileurl.outputs.base-url }} + # Outcome can be: 'success', 'failure', 'cancelled', or 'skipped' TEST_STATUS: ${{ steps.generate_video.outcome }} run: | MARKDOWN=$(node ./scripts/generateMarkdownSummary.js "${BASE_URL}" "${TEST_STATUS}") diff --git a/scripts/generateMarkdownSummary.js b/scripts/generateMarkdownSummary.js index 45729268..b8ec29a7 100755 --- a/scripts/generateMarkdownSummary.js +++ b/scripts/generateMarkdownSummary.js @@ -17,7 +17,7 @@ try { scenes = JSON.parse(fs.readFileSync('scenes.json', 'utf8')); } } catch (error) { - console.error('Warning: Could not read scenes.json:', error.message); + console.error('Warning: Could not read scenes.json - video segments will not be available:', error.message); } // Sanitize scene name to prevent path traversal