mirror of
https://github.com/arendst/Tasmota.git
synced 2026-07-27 20:05:46 +00:00
GrzegorzandGitHub
07154d430a
* MIELHVAC New features and bug fixes ## Changelog ### Bug Fixes **Memory leak in `miel_hvac_pre_init()`** — `goto del` jumped past the `free(sc)` label, leaking the allocated struct on serial init failure. Replaced with explicit `delete`/`free`/`return`. **`remotetemp_clear` semantics inverted** — variable was `true` on boot causing a CLR frame to be sent before any sensor registered. Renamed to `remotetemp_active`, initialised `false`. **`HVACSetPurify` used wrong map** — `airdirection_map` was passed instead of `purifier_map`. **`0x08` Set Run State flags wrong byte order** — flags are little-endian on the wire (ref: muart-group/muart-group.github.io#17). Removed `htons()` from all `0x08` flag assignments. **`widevane_isee` false positives** — values like `0x84`/`0x85`/`0x8c` (ISEE bit + position nibble) incorrectly reported `AirDirection:"even"`. Reverted to exact-match for `0x80`, `0x28`, `0xaa`. --- ### New Features **`0x42` HVAC Options polling** — added `miel_hvac_data_hvac_options` struct and `MIEL_HVAC_REQUEST_HVAC_OPTIONS` request. The unit is polled for Purifier, NightMode and EconoCool state. Requires short request form (len=1). Results stored in `sc_hvac_options` and published in SENSOR and HVACSETTINGS when `cap_run_state=true`. **Run State commands (`0x41 0x08`)** — new commands `HVACSetPurify`, `HVACSetNightMode`, `HVACSetEconoCool` and `HVACSetAirDirection` sent via `0x08` on units that report `cap_run_state=true`. Optimistic update to `sc_hvac_options` applied before confirmation. **EconoCool** — `0x08` byte 14, flag `0x10`, COOL mode only. Command `HVACSetEconoCool on|off`. **Base Capabilities (`0x5B 0xC9`)** — queried once after connecting. Parsed into `miel_hvac_capabilities`. Results published flat inside `MiElHVAC` as `*Supported` fields. Temperature ranges published as °C. Raw packet in `CapabilitiesHex`. **Capabilities-aware command validation** — commands blocked when unit reports feature unavailable: modes (heat/dry/fan), temperature range from capabilities, fan speeds, run state commands return `NotSupported` or `ControlNotSupported`. **`0x42` polling skip** — skipped on units with `cap_run_state=false`, eliminating recurring timeouts. **`miel_hvac_append_settings_json()`** — shared helper replacing ~80 lines of duplicated JSON code between SENSOR and HVACSETTINGS topics. --- ### JSON Changes - `Power` (W) and `Energy` (kWh) published inside `MiElHVAC` and also in a separate `ENERGY{}` object outside `MiElHVAC` for Home Assistant auto-discovery - `Purifier`, `NightMode`, `EconoCool` shown in SENSOR and HVACSETTINGS when `cap_run_state=true`; otherwise omitted - `AirDirection` always shows current state from `0x62 0x02` regardless of control support - `*Supported` capability fields published flat inside `MiElHVAC`: `HeatSupported`, `DrySupported`, `FanSupported`, `VaneVSupported`, `SwingSupported`, `AutoFanSupported`, `OutdoorTempSupported`, `AirDirectionSupported`, `PurifierSupported`, `NightModeSupported`, `EconoCoolSupported` --- ### Tested on MSZ-LN25VG2W — `cap_run_state=false`, temp ranges 16–31 °C cool/auto, 10–31 °C heat, 5 fan speeds. * Extend AirDirection capability, added web ui energy sensor, cleanup ### AirDirection — respect i-See sensor presence `AirDirection` now requires three conditions instead of just the vertical vane capability: - `cap_vane_v` — unit has a vertical vane - `sc_has_isee` — i-See sensor observed at runtime (widevane ever seen with bit `0x80`, or value `0x28`/`0xaa`) - `cap_run_state` — unit supports `0x08` for control Resulting behaviour: | `cap_vane_v` | `sc_has_isee` | `cap_run_state` | `AirDirection` visible | `AirDirectionSupported` | |:-:|:-:|:-:|:-:|:-:| | ❌ | — | — | hidden | `not_supported` | | ✅ | ❌ | — | hidden | `not_supported` | | ✅ | ✅ | ❌ | shown | `control_not_supported` | | ✅ | ✅ | ✅ | shown | `on` | Units with vertical + horizontal vanes but no i-See sensor now correctly report `AirDirectionSupported:"not_supported"` and omit `AirDirection` from both `MiElHVAC` and `HVACSettings` JSON. ### Capability field renames For naming consistency across the `*Supported` fields: - `cap_heat` → `cap_mode_heat`, `HeatSupported` → `ModeHeatSupported` - `cap_dry` → `cap_mode_dry`, `DrySupported` → `ModeDrySupported` - `cap_fan_mode` → `cap_mode_fan`, `FanSupported` → `ModeFanSupported` - `cap_auto_fan` → `cap_fan_auto`, `AutoFanSupported` → `FanAutoSupported` - `OutdoorTempSupported` → `OutdoorTemperatureSupported` - `TempCool` / `TempHeat` / `TempAuto` → `SetTemperatureCoolMinMax` / `SetTemperatureHeatMinMax` / `SetTemperatureAutoMinMax` ### Energy values - `Power` (W) and `Energy` (kWh) published both inside `MiElHVAC` and in a standard Tasmota `ENERGY{}` sub-object (`Power`/`Total`) for Home Assistant auto-discovery. - Added Web UI rows via `FUNC_WEB_SENSOR` showing instantaneous power (W) and cumulative total (kWh) on the Tasmota main page. ### Runtime i-See detection New `sc_has_isee` flag in `miel_hvac_softc`, set in `miel_hvac_input_settings` on the first widevane value indicating i-See state. Once set, stays set for the session. **Practical note:** after boot, the flag starts `false`. Units with i-See that has never been activated since Tasmota started will show `AirDirection` as hidden until i-See is first used (via IR remote or `HVACSetAirDirection`). Safe default — prevents showing misleading values on units without i-See. * MiElHVAC Full support of AirDirection control * MiELHVAC fix globals, VLA, duplicate JSON fields and float formatting ## Summary - **Remove file-scope globals** (`temp_type`, `remotetemp_active`, `remotetemp_auto_clear_time`, `remotetemp_last_call_time`, `remotetemp_half`): moved into `miel_hvac_softc` as `sc_temp_type` and `sc_remotetemp_*`. All references updated. Eliminates potential conflict with other drivers sharing the same translation unit. - **Fix VLA in `miel_hvac_send`**: `char hex_d[(len + 1) * 2]` replaced with fixed-size `(MIEL_HVAC_DATABUFLEN + 1) * 2`. Variable-length arrays on the stack are disallowed by `-Wvla` and unreliable on embedded targets. - **Make `temp_type` explicit**: helper functions `miel_hvac_deg2temp`, `miel_hvac_temp2deg`, `miel_hvac_roomtemp2deg` now take `bool temp_type` as a parameter. Detection of the extended encoding moved from render functions to `miel_hvac_input_data()`, removing a hidden side effect inside JSON serialisation code. - **Remove duplicate JSON fields**: `Purifier`, `NightMode`, `EconoCool` were emitted twice (from both the settings block and the options block). Options block now only emits `OptionsHex`. - **Fix `RemoteTemperatureSensorAutoClearTime` JSON type**: was serialised as a string (`"10000"`), now a proper JSON number (`10000`). - **Bool consistency**: assignments `= 1` / `= 0` on `bool` fields replaced with `= true` / `= false`.