From 43e3af1b81c4d3ef25afc6bdfcd1b91f84276f82 Mon Sep 17 00:00:00 2001
From: javl <mail@jaspervanloenen.com>
Date: Sat, 15 Aug 2026 08:55:09 +0200
Subject: [PATCH] Reuse method for glyphcomment instead of duplicate lines per
 section

---
 js/script.js | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)

diff --git a/js/script.js b/js/script.js
index 85d74fb..0ce7740 100644
--- a/js/script.js
+++ b/js/script.js
@@ -884,6 +884,13 @@ function getIdentifier() {
   return (vn && vn.value.length) ? vn.value : identifier;
 }
 
+// Builds the "// 'glyph', WxHpx" comment line placed before each image's
+// byte array, or '' when comments are disabled. Indent is prefixed when given.
+function glyphComment(image, indent = '') {
+  if (!settings.outputComments) return '';
+  return `${indent}// '${image.glyph}', ${image.canvas.width}x${image.canvas.height}px\n`;
+}
+
 // Output the image string to the textfield
 // eslint-disable-next-line no-unused-vars
 function generateOutputString() {
@@ -905,7 +912,7 @@ function generateOutputString() {
 
         code = `\t${code.split('\n').join('\n\t')}\n`;
         // const variableCount = images.length() > 1 ? count++ : '';
-        const comment = settings.outputComments ? `// '${image.glyph}', ${image.canvas.width}x${image.canvas.height}px\n` : '';
+        const comment = glyphComment(image);
         bytesUsed += code.split('\n').length * 16; // 16 bytes per line.
 
         const varname = getIdentifier() + (image.glyph ? image.glyph.replace(/[^a-zA-Z0-9]/g, '_') : '');
@@ -931,7 +938,7 @@ function generateOutputString() {
       images.each((image) => {
         code = imageToString(image);
         code = `\t${code.split('\n').join('\n\t')}\n`;
-        comment = settings.outputComments ? `\t// '${image.glyph}, ${image.canvas.width}x${image.canvas.height}px\n` : '';
+        comment = glyphComment(image, '\t');
         outputString += comment + code;
       });
 
@@ -950,7 +957,7 @@ function generateOutputString() {
       images.each((image) => {
         code = imageToString(image);
         code = `\t${code.split('\n').join('\n\t')}\n`;
-        comment = settings.outputComments ? `\t// '${image.glyph}', ${image.canvas.width}x${image.canvas.height}px\n` : '';
+        comment = glyphComment(image, '\t');
         outputString += comment + code;
         if (image.glyph.length === 1) {
           useGlyphs++;
@@ -1008,10 +1015,7 @@ function generateOutputString() {
     default: { // plain
       images.each((image) => {
         code = imageToString(image);
-        let comment = '';
-        if (image.glyph && settings.outputComments) {
-          comment = (`// '${image.glyph}', ${image.canvas.width}x${image.canvas.height}px\n`);
-        }
+        let comment = image.glyph ? glyphComment(image) : '';
         if (image.img !== images.first().img) {
           comment = `\n${comment}`;
         }