Michel2/leocad
1
0 Fork 0
mirror of https://github.com/leozide/leocad.git synced 2026-10-26 22:10:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

Bound grid generation for distant pieces

Browse Source 
A piece at an extreme coordinate expands the grid to millions of lines, causing excessive allocations or a truncated vertex buffer size followed by writes past its end. Larger coordinates can also exceed the integer range during conversion.

Clamp finite grid bounds before converting to integers, limiting the vertex buffer to less than 1 MB, and use the default grid for non-finite bounds. Calculate texture extents in floating point to avoid integer overflow with large spacing values.
This commit is contained in:
Leonardo Zide committed 2026-10-20 11:54:19 -07:00
1 parent e1c2df5767
commit 9709106aff
1 file changed
+11 -7
Download Patch File Download Diff File Expand all files Collapse all files
common/lc_view.cpp
+11 -7
View File
@@ -1640,12 +1640,16 @@ void lcView::DrawGrid()
}
}
if (GridSizeValid)
if (GridSizeValid && std::isfinite(Min[0]) && std::isfinite(Min[1]) && std::isfinite(Max[0]) && std::isfinite(Max[1]))
{
MinX = (int)(floorf(Min[0] / (20.0f * Spacing))) - 1;
MinY = (int)(floorf(Min[1] / (20.0f * Spacing))) - 1;
MaxX = (int)(ceilf(Max[0] / (20.0f * Spacing))) + 1;
MaxY = (int)(ceilf(Max[1] / (20.0f * Spacing))) + 1;
// Bound grid coordinates before converting to integers, keeping the vertex buffer below 1 MB.
constexpr float MaxGridExtent = 10000.0f;
const float GridSpacing = 20.0f * Spacing;
MinX = static_cast<int>(floorf(lcClamp(Min[0] / GridSpacing, -MaxGridExtent + 1.0f, MaxGridExtent - 1.0f))) - 1;
MinY = static_cast<int>(floorf(lcClamp(Min[1] / GridSpacing, -MaxGridExtent + 1.0f, MaxGridExtent - 1.0f))) - 1;
MaxX = static_cast<int>(ceilf(lcClamp(Max[0] / GridSpacing, -MaxGridExtent + 1.0f, MaxGridExtent - 1.0f))) + 1;
MaxY = static_cast<int>(ceilf(lcClamp(Max[1] / GridSpacing, -MaxGridExtent + 1.0f, MaxGridExtent - 1.0f))) + 1;
MinX = lcMin(MinX, -2);
MinY = lcMin(MinY, -2);
@@ -1689,8 +1693,8 @@ void lcView::DrawGrid()
float Top = MinY * 20.0f * Spacing;
float Bottom = MaxY * 20.0f * Spacing;
float Z = 0;
float U = (MaxX - MinX) * Spacing;
float V = (MaxY - MinY) * Spacing;
float U = (MaxX - MinX) * static_cast<float>(Spacing);
float V = (MaxY - MinY) * static_cast<float>(Spacing);
*CurVert++ = Left;
*CurVert++ = Top;