Michel2/leocad
1
0 Fork 0
mirror of https://github.com/leozide/leocad.git synced 2026-10-26 22:10:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

Keep asset refresh orchestration in the library

Browse Source 
Keep the persistent registry of live synth instances in the library, where
settings changes can refresh completed and failed generations through the
normal request lifecycle. The loader retains only pending work and errors.

After draining assigned jobs to change shared settings safely, resume
replacement work asynchronously instead of waiting for unrelated queued
assets. Rebuild model geometry through the normal loader entry point,
invalidating stale requests without adding a consumer reference.

Reduce the loader's public API, group its declarations by responsibility,
and document the ownership and asynchronous refresh behavior.

Validated with the Qt Debug build, loader lifecycle and scheduling regression
checks, model and synth refresh checks, and 14 first/repeat export checks.
This commit is contained in:
Leonardo Zide committed 2026-10-16 15:17:40 -07:00
1 parent 6795887758
commit c7de6bfecc
5 files changed
+71 -69
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

common/lc_assetloader.cpp
-36
View File
@@ -138,7 +138,6 @@ void lcAssetLoader::RequestSynthMesh(lcPiece* Piece)
if (mStopping)
return;
mSynthPieces.insert(Piece);
mSynthRequests.emplace(Piece, RequestedSynth);
DispatchJobs();
@@ -1064,29 +1063,6 @@ QString lcAssetLoader::GetSynthMeshError(const lcPiece* Piece) const
return It != mSynthErrors.end() ? It->second : QString();
}
void lcAssetLoader::RebuildModelPiece(PieceInfo* Info)
{
Q_ASSERT(QThread::currentThread() == thread());
Q_ASSERT(Info->IsModel());
if (Info->IsLoading())
WaitForPieceRequest(Info);
Info->ReleaseMesh();
mLibrary->ClearPieceLoadError(Info);
if (!Info->GetModel()->HasDirectGeometry())
{
Info->mState = lcPieceInfoState::Loaded;
emit mLibrary->AssetRequestsChanged();
return;
}
Info->mState = lcPieceInfoState::Unloaded;
QueuePieceLoad(Info, lcPieceLoadPriority::Normal);
}
void lcAssetLoader::InvalidatePieceLoad(PieceInfo* Info)
{
Q_ASSERT(QThread::currentThread() == thread());
@@ -1126,7 +1102,6 @@ void lcAssetLoader::CancelSynthMesh(lcPiece* Piece)
// Remove queued work immediately; running synth builds notice cancellation cooperatively.
Q_ASSERT(QThread::currentThread() == thread());
mSynthPieces.erase(Piece);
mSynthErrors.erase(Piece);
for (SynthNotification& Pending : mSynthNotifications)
@@ -1207,16 +1182,6 @@ void lcAssetLoader::CancelUnusedTextureRequests()
}
}
void lcAssetLoader::RebuildSynthMeshes()
{
Q_ASSERT(QThread::currentThread() == thread());
const std::vector<lcPiece*> Pieces(mSynthPieces.begin(), mSynthPieces.end());
for (lcPiece* Piece : Pieces)
Piece->RefreshGeneratedMesh();
}
void lcAssetLoader::PauseQueuedWork()
{
Q_ASSERT(QThread::currentThread() == thread());
@@ -1285,7 +1250,6 @@ void lcAssetLoader::Shutdown()
std::deque<std::shared_ptr<TextureRequest>> CancelledTextures;
mStopping = true;
mSynthPieces.clear();
mSynthErrors.clear();
for (auto It = mPieceRequests.begin(); It != mPieceRequests.end();)