Michel2/pybricks-code
1
0
Fork 0
mirror of https://github.com/pybricks/pybricks-code.git synced 2026-09-12 09:36:27 +00:00
Code Issues Releases Activity

ble/sagas: avoid Linux 5 second disconnect when possible

Browse Source 
If the user did not request disconnection, then we know this is a true
disconnect event and not an early one so we don't need the delay hack
in that case.

Issue: https://github.com/pybricks/support/issues/600
Issue: https://github.com/pybricks/support/issues/1021
This commit is contained in:
David Lechner
2023-04-01 13:38:19 -05:00
committed by David Lechner
parent 73248fe6aa
commit 3baaff5b61
1 changed files with 13 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ble/sagas.ts
+13 -6
View File
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: MIT
// Copyright (c) 2020-2022 The Pybricks Authors
// Copyright (c) 2020-2023 The Pybricks Authors
//
// Manages connection to a Bluetooth Low Energy device running Pybricks firmware.
@@ -434,14 +434,21 @@ function* handleBleConnectPybricks(): Generator {
// wait for disconnection
yield* take(disconnectChannel);
// HACK: Disconnection event comes early on Linux, so scanning again
// can show that the previous connection is still "paired" and trying
// to select it results in infinite wait. To work around this, we need
// to wait long enough for BlueZ to actually disconnect the device.
// HACK: Disconnection event comes early on Linux when server.disconnect()
// is called, so scanning again can show that the previous connection is
// still "paired" and trying to select it results in an infinite wait.
// To work around this, we need to wait long enough for BlueZ to actually
// disconnect the device.
// https://github.com/pybricks/support/issues/600#issuecomment-1286606624
// istanbul ignore if
if (process.env.NODE_ENV !== 'test' && isLinux()) {
yield* delay(5000);
const wasDisconnectRequestedByUser = yield* select(
(s: RootState) => s.ble.connection === BleConnectionState.Disconnecting,
);
if (wasDisconnectRequestedByUser) {
yield* delay(5000);
}
}
yield* put(bleDidDisconnectPybricks());