Michel2/pybricks-code
1
0
Fork 0
mirror of https://github.com/pybricks/pybricks-code.git synced 2026-09-12 09:36:27 +00:00
Code Issues Releases Activity

terminal: move handleKeyDown inside of useEffect()

Browse Source 
This will avoid extra renders triggered by a new handleKeyDown function.
This commit is contained in:
David Lechner
2022-05-18 10:26:48 -05:00
parent df6e93407e
commit 4384f80f9b
1 changed files with 22 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/terminal/Terminal.tsx
+22 -22
View File
@@ -133,29 +133,29 @@ const Terminal: React.FC = (_props) => {
};
}, [isDarkMode]);
const handleKeyDownEvent = (e: KeyboardEvent): void => {
// implement CTRL+SHIFT+C keyboard shortcut for copying text from terminal
if (e.key === 'C' && e.ctrlKey && e.shiftKey && !e.altKey && !e.metaKey) {
// this would otherwise open up debug console in web browser
e.preventDefault();
if (
document.hasFocus() &&
document.activeElement ===
terminalRef.current?.getElementsByClassName(
'xterm-helper-textarea',
)[0] &&
xterm.hasSelection()
) {
navigator.clipboard.writeText(xterm.getSelection());
}
}
};
useEffect(() => {
window.addEventListener('keydown', handleKeyDownEvent);
return () => window.removeEventListener('keydown', handleKeyDownEvent);
}, [handleKeyDownEvent]);
const handleKeyDown = (e: KeyboardEvent): void => {
// implement CTRL+SHIFT+C keyboard shortcut for copying text from terminal
if (e.key === 'C' && e.ctrlKey && e.shiftKey && !e.altKey && !e.metaKey) {
// this would otherwise open up debug console in web browser
e.preventDefault();
if (
document.hasFocus() &&
document.activeElement ===
terminalRef.current?.getElementsByClassName(
'xterm-helper-textarea',
)[0] &&
xterm.hasSelection()
) {
navigator.clipboard.writeText(xterm.getSelection());
}
}
};
window.addEventListener('keydown', handleKeyDown);
return () => window.removeEventListener('keydown', handleKeyDown);
}, [terminalRef, xterm]);
// wire shared context to terminal output
useEffect(() => {