From 614e0b00743d2fb07d710078a28145336d04ab04 Mon Sep 17 00:00:00 2001 From: David Lechner Date: Tue, 6 Dec 2022 15:50:35 -0600 Subject: [PATCH] firmware: remove android check for chunk size This should no longer be needed since Chrome v98 (released Nov. 2021). --- CHANGELOG.md | 6 ++++-- src/firmware/sagas.ts | 6 ++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index af3744ae..05d02675 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,9 +9,11 @@ ### Fixed - Fixed first tour item not shown if settings is not open ([support#823]). -- Fixed selected activity tab not controlled independently per window ([support#807]); -- Fixed selected documentation visibility not controlled independently per window ([support#807]); +- Fixed selected activity tab not controlled independently per window ([support#807]). +- Fixed selected documentation visibility not controlled independently per window ([support#807]). +- Fixed slow firmware flash on Android ([support#438]). +[support#438]: https://github.com/pybricks/support/issues/438 [support#778]: https://github.com/pybricks/support/issues/778 [support#807]: https://github.com/pybricks/support/issues/807 [support#823]: https://github.com/pybricks/support/issues/823 diff --git a/src/firmware/sagas.ts b/src/firmware/sagas.ts index 51ffbcc1..214bfb4f 100644 --- a/src/firmware/sagas.ts +++ b/src/firmware/sagas.ts @@ -63,7 +63,6 @@ import { RootState } from '../reducers'; import { LegoUsbProductId, legoUsbVendorId } from '../usb'; import { defined, ensureError, hex, maybe } from '../utils'; import { crc32, fmod, sumComplement32 } from '../utils/math'; -import { isAndroid } from '../utils/os'; import { FailToFinishReasonType, HubError, @@ -485,9 +484,8 @@ function* handleFlashFirmware(action: ReturnType): Generat yield* disconnectAndCancel(); } - // 14 is "safe" size for all hubs and Android - const maxDataSize = - (!isAndroid() && MaxProgramFlashSize.get(info.hubType)) || 14; + // 14 is "safe" size for all hubs + const maxDataSize = MaxProgramFlashSize.get(info.hubType) || 14; let runningChecksum = 0xff;