From 62d7fdff363df1f8b3b434c7df01318e5c2824cb Mon Sep 17 00:00:00 2001 From: David Lechner Date: Fri, 30 Dec 2022 16:07:52 -0600 Subject: [PATCH] editor/sagas: disable code completion trigger on space This gets in the way when typing comments and often results in accepting a completion that was not intended. Fixes: https://github.com/pybricks/support/issues/894 --- CHANGELOG.md | 4 +++- src/editor/sagas.ts | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e86fae31..42af1092 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,12 +5,14 @@ ## [Unreleased] ### Changed -- Code completion trigger improvements. +- Code completion trigger improvements ([support#894]). ### Fixed - Fixed terminal layout issues when resizing window vertically. - Fixed editor find widget visible over modal dialogs. +[support#894]: https://github.com/pybricks/support/issues/894 + ## [2.1.0-beta.3] - 2022-12-28 ### Changed diff --git a/src/editor/sagas.ts b/src/editor/sagas.ts index 219097c6..0fc37c71 100644 --- a/src/editor/sagas.ts +++ b/src/editor/sagas.ts @@ -606,7 +606,7 @@ function* runJedi(): Generator { const subscription = monaco.languages.registerCompletionItemProvider( pybricksMicroPythonId, { - triggerCharacters: ['.', ' '], + triggerCharacters: ['.'], provideCompletionItems( model, position,