From 68810f071ae13c394a42486727e8f88497536bba Mon Sep 17 00:00:00 2001 From: Laurens Valk Date: Thu, 3 Nov 2022 13:23:21 +0100 Subject: [PATCH] explorer/newFileWizard: Invert template inclusion UI. Instead of having the option to delete the template after selecting it, it is more intuitive to have a toggle for including it. --- src/explorer/newFileWizard/NewFileWizard.tsx | 28 +++++++++---------- .../newFileWizard/translations/en.json | 4 +-- 2 files changed, 16 insertions(+), 16 deletions(-) diff --git a/src/explorer/newFileWizard/NewFileWizard.tsx b/src/explorer/newFileWizard/NewFileWizard.tsx index 63227c21..65130ce2 100644 --- a/src/explorer/newFileWizard/NewFileWizard.tsx +++ b/src/explorer/newFileWizard/NewFileWizard.tsx @@ -23,9 +23,9 @@ const NewFileWizard: React.VoidFunctionComponent = () => { const i18n = useI18n(); const dispatch = useDispatch(); - const [emptyFile, setEmptyFile] = useLocalStorage( - 'explorer.newFileWizard.emptyFile', - false, + const [useTemplate, setuseTemplate] = useLocalStorage( + 'explorer.newFileWizard.useTemplate', + true, ); const isOpen = useSelector((s) => s.explorer.newFileWizard.isOpen); const [fileName, setFileName] = useState(''); @@ -46,11 +46,11 @@ const NewFileWizard: React.VoidFunctionComponent = () => { newFileWizardDidAccept( fileName, pythonFileExtension, - emptyFile ? undefined : hubType, + useTemplate ? hubType : undefined, ), ); }, - [dispatch, fileName, pythonFileExtension, hubType, emptyFile], + [dispatch, fileName, pythonFileExtension, hubType, useTemplate], ); const handleClose = useCallback(() => { @@ -77,20 +77,20 @@ const NewFileWizard: React.VoidFunctionComponent = () => { inputRef={fileNameInputRef} onChange={setFileName} /> - - - - setEmptyFile((e.target as HTMLInputElement).checked) + setuseTemplate((e.target as HTMLInputElement).checked) } > - {i18n.translate('emptyFile.label')} + {i18n.translate('useTemplate.label')} + + +
diff --git a/src/explorer/newFileWizard/translations/en.json b/src/explorer/newFileWizard/translations/en.json index ac2695f6..5a21b7a6 100644 --- a/src/explorer/newFileWizard/translations/en.json +++ b/src/explorer/newFileWizard/translations/en.json @@ -3,8 +3,8 @@ "template": { "label": "Template" }, - "emptyFile": { - "label": "Create an empty file" + "useTemplate": { + "label": "Include template" }, "action": { "create": "Create"