From 6911bdd3dab8686b6672970afb7c4cd79c829882 Mon Sep 17 00:00:00 2001 From: David Lechner Date: Sun, 4 Jan 2026 23:12:54 +0000 Subject: [PATCH] firmware/sagas: fix duplicate error alerts for ev3 flashing Remove alertsShowAlert() calls. didFailToFinish() already triggers an error toast. --- src/firmware/sagas.ts | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/src/firmware/sagas.ts b/src/firmware/sagas.ts index f6f938f3..69a62477 100644 --- a/src/firmware/sagas.ts +++ b/src/firmware/sagas.ts @@ -1230,11 +1230,6 @@ function* handleFlashEV3(action: ReturnType): Generator ); if (eraseError) { - yield* put( - alertsShowAlert('alerts', 'unexpectedError', { - error: eraseError, - }), - ); yield* put(alertsHideAlert(firmwareEv3ProgressToastId)); // FIXME: should have a better error reason yield* put(didFailToFinish(FailToFinishReasonType.Unknown, eraseError)); @@ -1248,11 +1243,6 @@ function* handleFlashEV3(action: ReturnType): Generator const [, sendError] = yield* sendCommand(0xf2, new Uint8Array(payload)); if (sendError) { - yield* put( - alertsShowAlert('alerts', 'unexpectedError', { - error: sendError, - }), - ); yield* put(alertsHideAlert(firmwareEv3ProgressToastId)); // FIXME: should have a better error reason yield* put(didFailToFinish(FailToFinishReasonType.Unknown, sendError));