From 7d5c9710e50c17d0d4dfb001f2a76adca6eb1d29 Mon Sep 17 00:00:00 2001
From: David Lechner <david@pybricks.com>
Date: Fri, 30 Dec 2022 16:04:48 -0600
Subject: [PATCH] editor/sagas: fix signature trigger characters

The intended behavior is that comma should trigger signature help when
it is not showing. retrigger only triggers if already showing.
---
 CHANGELOG.md        | 3 +++
 src/editor/sagas.ts | 4 ++--
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 4208a37a..e86fae31 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -4,6 +4,9 @@
 
 ## [Unreleased]
 
+### Changed
+- Code completion trigger improvements.
+
 ### Fixed
 - Fixed terminal layout issues when resizing window vertically.
 - Fixed editor find widget visible over modal dialogs.
diff --git a/src/editor/sagas.ts b/src/editor/sagas.ts
index 9b93eb61..219097c6 100644
--- a/src/editor/sagas.ts
+++ b/src/editor/sagas.ts
@@ -635,8 +635,8 @@ function* runJedi(): Generator {
             const subscription = monaco.languages.registerSignatureHelpProvider(
                 pybricksMicroPythonId,
                 {
-                    signatureHelpTriggerCharacters: ['('],
-                    signatureHelpRetriggerCharacters: [','],
+                    signatureHelpTriggerCharacters: ['(', ','],
+                    signatureHelpRetriggerCharacters: [')'],
                     provideSignatureHelp(model, position, token, context) {
                         return new Promise((resolve) => {
                             emit({ model, position, token, context, resolve });