From 964c18f12e22a53ac730cb4431594ce7f89eddf5 Mon Sep 17 00:00:00 2001 From: David Lechner Date: Fri, 21 Oct 2022 15:01:07 -0500 Subject: [PATCH] ble/sagas: fix blePybricksServiceDidNotReceiveHubCapabilities firmware version We were using the version from the @pybricks/firmware package but we really want the version from the connected device. --- src/ble/sagas.test.ts | 2 +- src/ble/sagas.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ble/sagas.test.ts b/src/ble/sagas.test.ts index 61481db8..87691c14 100644 --- a/src/ble/sagas.test.ts +++ b/src/ble/sagas.test.ts @@ -235,7 +235,7 @@ async function runConnectUntil(saga: AsyncSaga, point: ConnectRunPoint): Promise } await expect(saga.take()).resolves.toEqual( - blePybricksServiceDidNotReceiveHubCapabilities(pnpId, '3.2.0b4'), + blePybricksServiceDidNotReceiveHubCapabilities(pnpId, '3.2.0b2'), ); if (point === ConnectRunPoint.DidNotReceiveHubCapabilities) { diff --git a/src/ble/sagas.ts b/src/ble/sagas.ts index c81695f0..e0746877 100644 --- a/src/ble/sagas.ts +++ b/src/ble/sagas.ts @@ -363,7 +363,7 @@ function* handleBleConnectPybricks(): Generator { ); } else { yield* put( - blePybricksServiceDidNotReceiveHubCapabilities(pnpId, firmwareVersion), + blePybricksServiceDidNotReceiveHubCapabilities(pnpId, firmwareRevision), ); }