Michel2/pybricks-code
1
0
Fork 0
mirror of https://github.com/pybricks/pybricks-code.git synced 2026-09-12 17:45:22 +00:00
Code Issues Releases Activity

utils/react: add pointerEventsNone helper

Browse Source 
This should prevent some unnecessary rerendering by not creating a new
inline object.
This commit is contained in:
David Lechner
2022-03-12 15:26:48 -06:00
parent c51669c357
commit a2ccd3afdb
3 changed files with 9 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/toolbar/ActionButton.tsx
+3 -5
View File
@@ -13,7 +13,7 @@ import { Tooltip2 } from '@blueprintjs/popover2';
import { useI18n } from '@shopify/react-i18n';
import React, { useEffect, useMemo, useState } from 'react';
import { tooltipDelay } from '../app/constants';
import { preventFocusOnClick } from '../utils/react';
import { pointerEventsNone, preventFocusOnClick } from '../utils/react';
import { TooltipId } from './i18n';
import en from './i18n.en.json';
@@ -108,9 +108,7 @@ const ActionButton: React.FC<ActionButtonProps> = (props) => {
onMouseDown={preventFocusOnClick}
onClick={props.onAction}
disabled={props.enabled === false}
style={
props.enabled === false ? { pointerEvents: 'none' } : undefined
}
style={props.enabled === false ? pointerEventsNone : undefined}
>
{props.showProgress ? (
<Spinner
@@ -124,7 +122,7 @@ const ActionButton: React.FC<ActionButtonProps> = (props) => {
height={`${buttonSize}px`}
src={props.icon}
alt={props.id}
style={{ pointerEvents: 'none' }}
style={pointerEventsNone}
/>
)}
</Button>
src/toolbar/OpenFileButton.tsx
+3 -6
View File
@@ -7,7 +7,7 @@ import { useI18n } from '@shopify/react-i18n';
import React, { useEffect, useState } from 'react';
import { useDropzone } from 'react-dropzone';
import { tooltipDelay } from '../app/constants';
import { preventFocusOnClick } from '../utils/react';
import { pointerEventsNone, preventFocusOnClick } from '../utils/react';
import { TooltipId } from './i18n';
import en from './i18n.en.json';
@@ -120,10 +120,7 @@ const OpenFileButton: React.FC<OpenFileButtonProps> = (props) => {
...tooltipTargetProps,
intent: Intent.PRIMARY,
disabled: props.enabled === false,
style:
props.enabled === false
? { pointerEvents: 'none' }
: undefined,
style: props.enabled === false ? pointerEventsNone : undefined,
onMouseDown: preventFocusOnClick,
onClick: props.onClick,
})}
@@ -141,7 +138,7 @@ const OpenFileButton: React.FC<OpenFileButtonProps> = (props) => {
height={`${buttonSize}px`}
src={props.icon}
alt={props.id}
style={{ pointerEvents: 'none' }}
style={pointerEventsNone}
/>
)}
</Button>