mirror of
https://github.com/pybricks/pybricks-code.git
synced 2026-09-14 18:46:17 +00:00
tree-wide: fix version comparison
We were using satisfies in a few places where we should have just been using a comparison operator.
This commit is contained in:
+3
-3
@@ -8,7 +8,7 @@
|
||||
|
||||
import { firmwareVersion } from '@pybricks/firmware';
|
||||
import { Task, buffers, eventChannel } from 'redux-saga';
|
||||
import { satisfies } from 'semver';
|
||||
import { lt, satisfies } from 'semver';
|
||||
import {
|
||||
call,
|
||||
cancel,
|
||||
@@ -223,9 +223,9 @@ function* handleBleConnectPybricks(): Generator {
|
||||
|
||||
// notify user if old firmware
|
||||
if (
|
||||
satisfies(
|
||||
lt(
|
||||
pythonVersionToSemver(firmwareRevision),
|
||||
`<${pythonVersionToSemver(firmwareVersion)}`,
|
||||
pythonVersionToSemver(firmwareVersion),
|
||||
)
|
||||
) {
|
||||
yield* put(alertsShowAlert('ble', 'oldFirmware'));
|
||||
|
||||
Reference in New Issue
Block a user