mirror of
https://github.com/pybricks/pybricks-code.git
synced 2026-09-12 17:45:22 +00:00
firmware/sagas: fix checksum validation
The checksum can be 0, so we can't be lazy and use `!checksum` to test for undefined. Issue: https://github.com/pybricks/support/issues/724#issuecomment-1295929316
This commit is contained in:
committed by
David Lechner
parent
2d9a0ca39e
commit
cb5101282b
@@ -309,7 +309,7 @@ function* loadFirmware(
|
||||
}
|
||||
})();
|
||||
|
||||
if (!checksum) {
|
||||
if (checksum === undefined) {
|
||||
// FIXME: we should return error/throw instead
|
||||
yield* put(
|
||||
didFailToFinish(
|
||||
@@ -352,7 +352,7 @@ function* loadFirmware(
|
||||
}
|
||||
})();
|
||||
|
||||
if (!checksum) {
|
||||
if (checksum === undefined) {
|
||||
// FIXME: we should return error/throw instead
|
||||
yield* put(
|
||||
didFailToFinish(
|
||||
|
||||
Reference in New Issue
Block a user