From d00297f53b78e8299ab755fc9fe5f418ae65a773 Mon Sep 17 00:00:00 2001 From: David Lechner Date: Fri, 16 Dec 2022 12:30:32 -0600 Subject: [PATCH] app: drop focus-within styling This ended up causing dual focus rings which goes against ARIA recommendations. --- src/app/app.scss | 2 -- src/variables.scss | 16 ---------------- 2 files changed, 18 deletions(-) diff --git a/src/app/app.scss b/src/app/app.scss index 57c825c3..f3bee846 100644 --- a/src/app/app.scss +++ b/src/app/app.scss @@ -23,7 +23,6 @@ &-activities { display: flex; - @include pb.focus-within(); } &-terminal { @@ -31,7 +30,6 @@ padding-top: 8px; padding-left: 8px; background-color: white; - @include pb.focus-within(); .#{bp.$ns}-dark & { background-color: black; diff --git a/src/variables.scss b/src/variables.scss index ca2f6694..196ed63c 100644 --- a/src/variables.scss +++ b/src/variables.scss @@ -46,19 +46,3 @@ $pt-dark-outline-color: rgba(bp.$blue5, 0.6); outline-offset: $offset; } } - -// add a focus ring when focus is within a container -@mixin focus-within() { - position: relative; - - &:focus-within::after { - content: ''; - pointer-events: none; - position: absolute; - top: 0; - left: 0; - width: 100%; - height: 100%; - @include focus-outline(-3px); - } -}