From d19ded5908891ffe9f6adad85be29eaf390d499c Mon Sep 17 00:00:00 2001 From: James Aguilar Date: Sat, 3 Jan 2026 22:06:42 -0500 Subject: [PATCH] firmware/ev3: Don't request hardware version. This feature doesn't seem to work when it is issued from a USB3 bus. See https://github.com/pybricks/support/issues/2515. Since we don't use the version, removing the command is harmless. --- src/firmware/sagas.ts | 22 ---------------------- 1 file changed, 22 deletions(-) diff --git a/src/firmware/sagas.ts b/src/firmware/sagas.ts index be910740..f6f938f3 100644 --- a/src/firmware/sagas.ts +++ b/src/firmware/sagas.ts @@ -1211,28 +1211,6 @@ function* handleFlashEV3(action: ReturnType): Generator return [new DataView(reply.payload), undefined]; } - const [version, versionError] = yield* sendCommand(0xf6); // get version - - if (versionError) { - yield* put( - alertsShowAlert('alerts', 'unexpectedError', { - error: ensureError(versionError), - }), - ); - yield* put(firmwareDidFailToFlashEV3()); - yield* cleanup(); - return; - } - - defined(version); - - console.debug( - `EV3 bootloader version: ${version.getUint32( - 0, - true, - )}, HW version: ${version.getUint32(4, true)}`, - ); - // FIXME: should be called much earlier. yield* put(didStart());