Michel2/pybricks-code
1
0
Fork 0
mirror of https://github.com/pybricks/pybricks-code.git synced 2026-09-15 02:54:07 +00:00
Code Issues Releases Activity

test: wrap all user calls in act()

Browse Source 
Some user events trigger react dom changes. These need to be wrapped in
act() to avoid a warning printed to the console. To be save, we wrap
all instances.
This commit is contained in:
David Lechner
2023-03-10 18:16:27 -06:00
committed by David Lechner
parent 78290eb927
commit d88ce8998f
42 changed files with 212 additions and 172 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/about/AboutDialog.test.tsx
+5 -5
View File
@@ -1,7 +1,7 @@
// SPDX-License-Identifier: MIT
// Copyright (c) 2021-2022 The Pybricks Authors
// Copyright (c) 2021-2023 The Pybricks Authors
import { getByLabelText, waitFor } from '@testing-library/react';
import { act, getByLabelText, waitFor } from '@testing-library/react';
import React from 'react';
import { testRender } from '../../test';
import AboutDialog from './AboutDialog';
@@ -11,7 +11,7 @@ it('should close when the button is clicked', async () => {
const [user, dialog] = testRender(<AboutDialog isOpen={true} onClose={close} />);
await user.click(dialog.getByLabelText('Close'));
await act(() => user.click(dialog.getByLabelText('Close')));
expect(close).toHaveBeenCalled();
});
@@ -25,7 +25,7 @@ it('should manage license dialog open/close', async () => {
dialog.queryByRole('dialog', { name: 'Open Source Software Licenses' }),
).toBeNull();
await user.click(dialog.getByText('Software Licenses'));
await act(() => user.click(dialog.getByText('Software Licenses')));
const licenseDialog = dialog.getByRole('dialog', {
name: 'Open Source Software Licenses',
@@ -33,7 +33,7 @@ it('should manage license dialog open/close', async () => {
expect(licenseDialog).toBeVisible();
await user.click(getByLabelText(licenseDialog, 'Close'));
await act(() => user.click(getByLabelText(licenseDialog, 'Close')));
await waitFor(() => expect(licenseDialog).not.toBeVisible());
});