Michel2/pybricks-code
1
0
Fork 0
mirror of https://github.com/pybricks/pybricks-code.git synced 2026-09-14 18:46:17 +00:00
Code Issues Releases Activity

test: wrap all user calls in act()

Browse Source 
Some user events trigger react dom changes. These need to be wrapped in
act() to avoid a warning printed to the console. To be save, we wrap
all instances.
This commit is contained in:
David Lechner
2023-03-10 18:16:27 -06:00
committed by David Lechner
parent 78290eb927
commit d88ce8998f
42 changed files with 212 additions and 172 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/settings/Settings.test.tsx
+8 -8
View File
@@ -1,7 +1,7 @@
// SPDX-License-Identifier: MIT
// Copyright (c) 2022 The Pybricks Authors
// Copyright (c) 2022-2023 The Pybricks Authors
import { cleanup, getByLabelText, waitFor } from '@testing-library/react';
import { act, cleanup, getByLabelText, waitFor } from '@testing-library/react';
import React from 'react';
import { testRender } from '../../test';
import { firmwareInstallPybricks } from '../firmware/actions';
@@ -23,11 +23,11 @@ describe('darkMode setting switch', () => {
expect(darkMode).not.toBeChecked();
expect(localStorage.getItem('usehooks-ts-ternary-dark-mode')).toBe(null);
await user.click(darkMode);
await act(() => user.click(darkMode));
expect(darkMode).toBeChecked();
expect(localStorage.getItem('usehooks-ts-ternary-dark-mode')).toBe('"dark"');
await user.click(darkMode);
await act(() => user.click(darkMode));
expect(darkMode).not.toBeChecked();
expect(localStorage.getItem('usehooks-ts-ternary-dark-mode')).toBe('"light"');
});
@@ -40,7 +40,7 @@ describe('firmware', () => {
const button = settings.getByRole('button', {
name: 'Install Pybricks Firmware',
});
await user.click(button);
await act(() => user.click(button));
expect(dispatch).toHaveBeenCalledWith(firmwareInstallPybricks());
});
@@ -51,7 +51,7 @@ describe('firmware', () => {
const button = settings.getByRole('button', {
name: 'Restore Official LEGO® Firmware',
});
await user.click(button);
await act(() => user.click(button));
expect(dispatch).toHaveBeenCalledWith(firmwareRestoreOfficialDialogShow());
});
@@ -65,13 +65,13 @@ describe('about dialog', () => {
expect(settings.queryByRole('dialog', { name: `About ${appName}` })).toBeNull();
await user.click(settings.getByText('About'));
await act(() => user.click(settings.getByText('About')));
const dialog = settings.getByRole('dialog', { name: `About ${appName}` });
expect(dialog).toBeVisible();
await user.click(getByLabelText(dialog, 'Close'));
await act(() => user.click(getByLabelText(dialog, 'Close')));
await waitFor(() => expect(dialog).not.toBeVisible());
});