From de237b13f953a8d53fac25003f91f2a2b47ac752 Mon Sep 17 00:00:00 2001 From: Andreas Litt Date: Sun, 13 Dec 2020 21:34:16 +0100 Subject: [PATCH] remove stickiness of toolbar to avoid breaking the layout clicking on a link with a URI fragment (e.g. https://docs.pybricks.com/en/latest/parameters.html#pybricks.parameters.Port) inside the documentation iframe breaks the layout. The browser seems to force the parent frame to scroll to the position as well. As the toolbar is fixed, the rest of the content is scrolled under it. Rerendering after the link click fixes the layout (at least if done manually). But a more elegant solutions is to remove the absolute positioning of the toolbar. It is not really necessary to pin it, as the rest of the layout always spans over the complete width and height of the browser window. --- src/components/Toolbar.tsx | 1 - src/index.scss | 2 -- 2 files changed, 3 deletions(-) diff --git a/src/components/Toolbar.tsx b/src/components/Toolbar.tsx index 44207f29..f1d38e41 100644 --- a/src/components/Toolbar.tsx +++ b/src/components/Toolbar.tsx @@ -18,7 +18,6 @@ class Toolbar extends React.Component { return ( e.preventDefault()} - fixedToTop={true} className="no-box-shadow" > diff --git a/src/index.scss b/src/index.scss index 2f13c62d..f251ffe8 100644 --- a/src/index.scss +++ b/src/index.scss @@ -28,8 +28,6 @@ $status-bar-height: 3vh; body { // no scrolling of the page overflow: hidden; - // See https://blueprintjs.com/docs/#core/components/navbar - padding-top: $pt-navbar-height; } // Utility classes