From df6e93407e4ef549071ca0698fd2811c7f872c2d Mon Sep 17 00:00:00 2001 From: David Lechner Date: Wed, 18 May 2022 10:13:31 -0500 Subject: [PATCH] terminal: remove questionable tabindex Not sure if this has a purpose I don't know about but removing it gives better behavior when using keyboard navigation. --- src/terminal/Terminal.tsx | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/terminal/Terminal.tsx b/src/terminal/Terminal.tsx index 809e8815..f13b2574 100644 --- a/src/terminal/Terminal.tsx +++ b/src/terminal/Terminal.tsx @@ -115,6 +115,10 @@ const Terminal: React.FC = (_props) => { xterm.open(terminalRef.current); fitAddon.fit(); + // HACK: remove tabindex from main xterm element, otherwise it takes + // two tabs to get to the text area + xterm.element?.removeAttribute('tabindex'); + return () => xterm.dispose(); }, [xterm]);