src/utils: add ensureError() function

Typescript v4.4 no longer assumes that the error in catch is an Error
object [1]. This adds a helper function to ensure that caught errors
at least match the Error interface. If not, it creates a new Error
object with the value as the message.

[1]: https://devblogs.microsoft.com/typescript/announcing-typescript-4-4-beta/#using-unknown-in-catch-variables
This commit is contained in:
David Lechner
2021-08-30 13:06:01 -05:00
committed by David Lechner
parent 79db359398
commit e7d44ea9a9
8 changed files with 78 additions and 34 deletions
+2 -1
View File
@@ -9,6 +9,7 @@ import { EventChannel, eventChannel } from 'redux-saga';
import { call, fork, put, select, take, takeEvery } from 'typed-redux-saga/macro';
import { AppActionType } from '../app/actions';
import { RootState } from '../reducers';
import { ensureError } from '../utils';
import {
SettingsActionType,
SettingsSetBooleanAction,
@@ -80,7 +81,7 @@ function* storeSetting(action: SettingsSetBooleanAction): Generator {
try {
localStorage.setItem(key, newValue);
} catch (err) {
yield* put(didFailToSetBoolean(action.id, err));
yield* put(didFailToSetBoolean(action.id, ensureError(err)));
}
// storage event is only raised when a value is changed externally, so we