From fa21abc7ecda4f9144827da673f3a929b8050931 Mon Sep 17 00:00:00 2001
From: David Lechner <david@lechnology.com>
Date: Sat, 30 Aug 2025 22:56:19 +0000
Subject: [PATCH] firmware/sagas: fix missing error arg when unknown reason

For some reason, the type checker doesn't catch this, but
FailToFinishReasonType.Unknown requires an error argument, otherwise
we get an unhandled exception.
---
 src/firmware/sagas.ts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/firmware/sagas.ts b/src/firmware/sagas.ts
index d4c3f469..a25e5b26 100644
--- a/src/firmware/sagas.ts
+++ b/src/firmware/sagas.ts
@@ -1251,7 +1251,7 @@ function* handleFlashEV3(action: ReturnType<typeof firmwareFlashEV3>): Generator
                 }),
             );
             // FIXME: should have a better error reason
-            yield* put(didFailToFinish(FailToFinishReasonType.Unknown));
+            yield* put(didFailToFinish(FailToFinishReasonType.Unknown, eraseError));
             yield* put(firmwareDidFailToFlashEV3());
             yield* cleanup();
             return;
@@ -1268,7 +1268,7 @@ function* handleFlashEV3(action: ReturnType<typeof firmwareFlashEV3>): Generator
                     }),
                 );
                 // FIXME: should have a better error reason
-                yield* put(didFailToFinish(FailToFinishReasonType.Unknown));
+                yield* put(didFailToFinish(FailToFinishReasonType.Unknown, sendError));
                 yield* put(firmwareDidFailToFlashEV3());
                 yield* cleanup();
                 return;
@@ -1309,7 +1309,7 @@ function* handleFlashEV3(action: ReturnType<typeof firmwareFlashEV3>): Generator
     const [, rebootError] = yield* sendCommand(0xf4); // start app
     if (rebootError) {
         // FIXME: should have a better error reason
-        yield* put(didFailToFinish(FailToFinishReasonType.Unknown));
+        yield* put(didFailToFinish(FailToFinishReasonType.Unknown, rebootError));
         yield* put(firmwareDidFailToFlashEV3());
         yield* cleanup();
         return;