Michel2/pybricks-code
1
0
Fork 0
mirror of https://github.com/pybricks/pybricks-code.git synced 2026-09-12 17:45:22 +00:00
Code Issues Releases Activity
2,205 Commits 12 Branches 59 Tags
7b0dc47b047bb82a9fb5642bc5d10f7ce5d37324
Commit Graph
30 Commits
Author SHA1 Message Date
dependabot[bot]andDavid Lechner 7b0dc47b04 build(deps): bump @blueprintjs/popover2 from 1.11.3 to 1.12.0 (#1454) 
* build(deps): bump @blueprintjs/popover2 from 1.11.3 to 1.12.0

Bumps [@blueprintjs/popover2](https://github.com/palantir/blueprint/tree/HEAD/packages/core) from 1.11.3 to 1.12.0.
- [Release notes](https://github.com/palantir/blueprint/releases)
- [Changelog](https://github.com/palantir/blueprint/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/palantir/blueprint/commits/@blueprintjs/popover2@1.12.0/packages/core)

---
updated-dependencies:
- dependency-name: "@blueprintjs/popover2"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* fix breaking change in blueprintjs popover2

work around https://github.com/palantir/blueprint/issues/5889

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: David Lechner <david@pybricks.com>
 2023-01-24 16:18:23 +00:00
David Lechner 9d71bb4734 eslint: enable react-hooks checks 
Also fix all errors, which can lead to subtile bugs.

Mostly fixings deps and refactoring to make typescript happy.
 2022-12-17 13:56:01 -06:00
David Lechner 9e62259845 toolbar/ActionButton: use aria-disabled 
Since buttons are only styled as disabled, we need to use aria-disabled
to tell screen readers that the button is disabled.
 2022-12-16 17:54:36 -06:00
David Lechner 303e768168 toolbar/ActionButton: improve focus ring visibility 
Since the button and the focus ring are both blue, we need a gap in
order to have enough contrast to see the focus ring.
 2022-12-16 17:54:36 -06:00
David Lechner e8b57fe3d9 toolbar/ActionButton: drop aria-haspopup workaround 
The fixe has been merged upstream.
 2022-11-23 17:20:45 -06:00
David Lechner d323db4d1b toolbar/ActionButton: only disable using style 
This removes use of the button disable property since it removes the
button from the accessibility tree and also makes tooltips not work.
The styling is kept the same by manually including the disable style.
 2022-11-23 17:20:45 -06:00
David Lechner b4e1c8293d replace use of deprecated IRef 2022-09-01 11:45:59 -05:00
David Lechner 0839392183 rework roving tab index to use react-aria 2022-05-17 23:20:09 -05:00
David Lechner 404818bcdf toolbar: use roving focus 2022-05-13 23:28:12 -05:00
David Lechner dc2daf2fe4 toolbar: hide icons from a11y tools 
There are already ARIA labels, so the icons should be hidden.
 2022-05-13 14:44:26 -05:00
David Lechner 7322c9d667 utils: drop pointerEventsNone 
Not sure why this was used in the first place, but causes non-default
behavior which can be confusing.
 2022-05-13 14:39:35 -05:00
David Lechner cd88789be7 toolbar: override aria-haspopup 
The Tooltip2 component incorrectly sets this attribute which should
not be set for tooltips.
 2022-05-13 14:38:12 -05:00
David Lechner 5dd61fa4c3 toolbar/buttons: consolidate buttons 2022-03-25 15:54:04 -05:00
David Lechner 9f254f035f i18n: use babel-loader plugin 2022-03-25 15:54:04 -05:00
David Lechner 46faff981d toolbar: add label to buttons 
This improves accessability by letting us get buttons by the label.
 2022-03-16 15:24:48 -05:00
David Lechner 675d01013d utils/react: drop preventFocusOnClick 
We can fix this better with css tweaks.
 2022-03-15 21:39:24 -05:00
David Lechner 8e4045449c src: use prop unpacking pattern 
This makes the code a bit shorter by not having to use `props.` all of
the time. Also make everything VoidFunctionComponent while we are
touching this.
 2022-03-12 16:07:31 -06:00
David Lechner a2ccd3afdb utils/react: add pointerEventsNone helper 
This should prevent some unnecessary rerendering by not creating a new
inline object.
 2022-03-12 15:26:48 -06:00
David Lechner c51669c357 fix deps in hotkeys memos 2022-03-12 15:19:50 -06:00
David Lechner de7e046d31 avoid lambda props 
This fixes the simple cases of callback props using lambda functions.
This will prevent rerendering in some cases since a new callback
function is not created on each call.
 2022-03-12 15:19:50 -06:00
David Lechner c229d407cf utils/react: add preventDefault helpers 
These can be used instead of always having to add a comment explaining
what preventDefault does in a given context.
 2022-03-12 14:57:30 -06:00
David Lechner a0a1ae7126 "@blueprintjs/core": "^3.53.0" 
This allows us to drop the monkey patch to work around an upstream bug.
 2022-02-22 14:23:20 -06:00
David Lechner fd09783a45 toolbar: work around tooltip bugs 
This works around several bugs where tooltips don't close when expected.

Fixes: https://github.com/pybricks/pybricks-code/issues/275
 2021-12-28 18:55:20 -06:00
David Lechner 09b46ed5be toolbar: make buttons scale with screen size 
This is very basic, just 2 sizes. But it makes things a bit better
on phones.

Fixes: https://github.com/pybricks/support/issues/300
 2021-12-27 12:38:51 -06:00
David Lechner 6dc4dcb2e5 toolbar: specify image width/height 
This make the button the right size while waiting for the image to download.

Fixes: https://github.com/pybricks/support/issues/369
 2021-12-27 12:38:50 -06:00
David Lechner eb9ea2876e toolbar: remove unuse buttonRef in ActionButton 2021-12-27 12:38:50 -06:00
David Lechner 9be6ba3640 update to Tooltip2 
Tooltip has been deprecated so trying out the new Tooltip2.
 2021-12-27 12:38:50 -06:00
David Lechner f3e179683e toolbar: convert ActionButton to function 2021-12-27 12:38:50 -06:00
David Lechner e8c4472e50 Add progress bar for user program download. 2021-04-12 16:24:36 -05:00
David Lechner 6f204a65f6 reorganize src/ directory 
Makes for much less scrolling/jumping around.

https://redux.js.org/style-guide/style-guide#structure-files-as-feature-folders-or-ducks
 2021-02-01 10:26:05 -06:00