Create test-specific mock and rewrite all tests to use expandTopic with per-test data mocking

Co-authored-by: thomasnordquist <7721625+thomasnordquist@users.noreply.github.com>

.github/workflows/tests.yml

@@ -12,8 +12,6 @@ jobs:
       options: --user root
     steps:
       - uses: actions/checkout@v4
-        with:
-          ref: ${{ github.event.pull_request.head.sha }}
       - name: Install Packages
         run: yarn install --frozen-lockfile
       - name: Build
@@ -30,8 +28,6 @@ jobs:
       options: --user root
     steps:
       - uses: actions/checkout@v4
-        with:
-          ref: ${{ github.event.pull_request.head.sha }}
       - name: Install Packages
         run: yarn install --frozen-lockfile
       - name: Build
@@ -57,8 +53,6 @@ jobs:
       options: --user root
     steps:
       - uses: actions/checkout@v4
-        with:
-          ref: ${{ github.event.pull_request.head.sha }}
       - name: Install Packages
         run: yarn install --frozen-lockfile
       - name: Build
@@ -96,8 +90,6 @@ jobs:
           --health-retries 5
     steps:
       - uses: actions/checkout@v4
-        with:
-          ref: ${{ github.event.pull_request.head.sha }}
       - name: Setup Node.js
         uses: actions/setup-node@v4
         with:

app/package.json

@@ -92,6 +92,6 @@
     "webpack-dev-server": "^5.0.4"
   },
   "peerDependencies": {
-    "electron": "^39"
+    "electron": "^29"
   }
 }

backend/src/Model/Base64Message.ts

@@ -82,7 +82,7 @@ export class Base64Message {
 
     let str: string = ''
     buf.forEach(element => {
-      const hex = element.toString(16).toUpperCase()
+      let hex = element.toString(16).toUpperCase()
       str += `0x${hex.length < 2 ? '0' + hex : hex} `
     })
     return str.trimRight()

events/EventSystem/IpcMainEventBus.ts

@@ -26,11 +26,11 @@ export class IpcMainEventBus implements EventBusInterface {
           this.clients.delete(sender.id)
 
           // Clean up owned connections
-          Array.from(this.connectionOwners.entries()).forEach(([connectionId, webContentsId]) => {
+          for (const [connectionId, webContentsId] of this.connectionOwners.entries()) {
             if (webContentsId === sender.id) {
               this.connectionOwners.delete(connectionId)
             }
-          })
+          }
         })
       }
 

events/EventSystem/SocketIOServerEventBus.ts

@@ -23,7 +23,7 @@ export class SocketIOServerEventBus implements EventBusInterface {
   private globalHandlers: Map<string, (socket: Socket, arg: any) => void> = new Map()
 
   // Per-socket subscriptions for cleanup
-  private socketSubscriptions: Map<string, Array<SocketSubscription>> = new Map()
+  private socketSubscriptions: Map<string, SocketSubscription[]> = new Map()
 
   // Track which socket is currently processing a request
   private currentSocket: Socket | undefined

package.json

@@ -105,7 +105,7 @@
     "builder-util-runtime": "^9",
     "chai": "^4.2.0",
     "cspell": "^8.6.1",
-    "electron": "39.2.7",
+    "electron": "29.2.0",
     "electron-builder": "^24.13.3",
     "mocha": "^10.4.0",
     "mustache": "4",

src/server.ts

@@ -73,7 +73,7 @@ async function startServer() {
 
   backendRpc.on(makeSaveDialogRpc(), async request => {
     // In browser mode, file saving is handled client-side via download
-    return { canceled: true, filePath: '' }
+    return { canceled: true, filePath: undefined }
   })
 
   backendRpc.on(getAppVersion, async () => {

src/spec/mock-sparkplugb.ts

@@ -22,8 +22,8 @@ export interface MockSparkplugClient {
   stop: () => void
 }
 
-let sample = (function () {
-  let config = {
+var sample = (function () {
+  var config = {
       serverUrl: 'tcp://127.0.0.1:1883',
       username: '',
       password: '',
@@ -169,12 +169,12 @@ let sample = (function () {
       // Create node command handler
       // spell-checker: disable-next-line
       sparkplugClient.on('ncmd', function (payload: UPayload) {
-        let timestamp = payload.timestamp,
+        var timestamp = payload.timestamp,
           metrics = payload.metrics
 
         if (metrics !== undefined && metrics !== null) {
-          for (let i = 0; i < metrics.length; i++) {
-            let metric = metrics[i]
+          for (var i = 0; i < metrics.length; i++) {
+            var metric = metrics[i]
             if (metric.name == 'Node Control/Rebirth' && metric.value) {
               console.log("Received 'Rebirth' command")
               // Publish Node BIRTH certificate
@@ -189,7 +189,7 @@ let sample = (function () {
       // Create device command handler
       // spell-checker: disable-next-line
       sparkplugClient.on('dcmd', function (deviceId: string, payload: UPayload) {
-        let timestamp = payload.timestamp,
+        var timestamp = payload.timestamp,
           metrics = payload.metrics,
           inboundMetricMap: { [name: string]: any } = {},
           outboundMetric: Array<UMetric> = [],
@@ -199,8 +199,8 @@ let sample = (function () {
 
         // Loop over the metrics and store them in a map
         if (metrics !== undefined && metrics !== null) {
-          for (let i = 0; i < metrics.length; i++) {
-            let metric = metrics[i]
+          for (var i = 0; i < metrics.length; i++) {
+            var metric = metrics[i]
             if (metric.name !== undefined && metric.name !== null) {
               inboundMetricMap[metric.name] = metric.value
             }
@@ -239,7 +239,7 @@ let sample = (function () {
       return connected
     }
 
-  return { run }
+  return { run: run }
 })()
 
 export default sample

src/spec/testMcpIntrospection.ts

@@ -35,7 +35,7 @@ async function main() {
   console.log(`✓ Window ready, title: ${title}`)
 
   // Check console logs for remote debugging message
-  const logs: Array<string> = []
+  const logs: string[] = []
   page.on('console', msg => {
     const text = msg.text()
     logs.push(text)

src/spec/ui-tests.spec.ts

@@ -68,7 +68,7 @@ describe('MQTT Explorer UI Tests', function () {
       // When: Connect and expand topic
       await connectTo('127.0.0.1', page)
       await sleep(2000)
-      await expandTopic('livingroom/lamp', page)
+      await expandTopic(page, 'livingroom/lamp')
 
       // Then: Should see lamp state
       const stateTopic = await page.locator('span[data-test-topic="state"]')
@@ -97,7 +97,7 @@ describe('MQTT Explorer UI Tests', function () {
       // When: Connect and expand topic
       await connectTo('127.0.0.1', page)
       await sleep(2000)
-      await expandTopic('kitchen/coffee_maker', page)
+      await expandTopic(page, 'kitchen/coffee_maker')
 
       // Then: JSON content should be visible (check for heater key)
       const valueDisplay = await page.locator('text="heater"')
@@ -119,7 +119,7 @@ describe('MQTT Explorer UI Tests', function () {
       // When: Connect and expand to nested topic
       await connectTo('127.0.0.1', page)
       await sleep(2000)
-      await expandTopic('livingroom/lamp/brightness', page)
+      await expandTopic(page, 'livingroom/lamp/brightness')
 
       // Then: Brightness topic should be visible and selected
       const brightnessTopic = await page.locator('span[data-test-topic="brightness"]')
@@ -148,7 +148,7 @@ describe('MQTT Explorer UI Tests', function () {
       await sleep(1000)
       await clearSearch(page)
       await sleep(500)
-      await expandTopic('kitchen/temperature', page)
+      await expandTopic(page, 'kitchen/temperature')
 
       // Then: Temperature topic should be visible
       const tempTopic = await page.locator('span[data-test-topic="temperature"]')
@@ -175,7 +175,7 @@ describe('MQTT Explorer UI Tests', function () {
       await sleep(1000)
       await clearSearch(page)
       await sleep(500)
-      await expandTopic('kitchen/lamp', page)
+      await expandTopic(page, 'kitchen/lamp')
 
       // Then: Lamp topic should be visible
       const lampTopic = await page.locator('span[data-test-topic="lamp"]')

yarn.lock

@@ -1500,20 +1500,13 @@
   dependencies:
     undici-types "~7.16.0"
 
-"@types/node@>=13.7.0":
+"@types/node@>=13.7.0", "@types/node@^20.9.0":
   version "20.12.4"
   resolved "https://registry.npmjs.org/@types/node/-/node-20.12.4.tgz"
   integrity sha512-E+Fa9z3wSQpzgYQdYmme5X3OTuejnnTx88A6p6vkkJosR3KBz+HpE3kqNm98VE6cfLFcISx7zW7MsJkH6KwbTw==
   dependencies:
     undici-types "~5.26.4"
 
-"@types/node@^22.7.7":
-  version "22.19.3"
-  resolved "https://registry.yarnpkg.com/@types/node/-/node-22.19.3.tgz#8dfde7630d7a8528dc9b34db23d34f764467c02c"
-  integrity sha512-1N9SBnWYOJTrNZCdh/yJE+t910Y128BoyY+zBLWhL3r0TYzlTmFdXrPwHL9DyFZmlEXNQQolTZh3KHV31QDhyA==
-  dependencies:
-    undici-types "~6.21.0"
-
 "@types/normalize-package-data@^2.4.3":
   version "2.4.4"
   resolved "https://registry.yarnpkg.com/@types/normalize-package-data/-/normalize-package-data-2.4.4.tgz#56e2cc26c397c038fab0e3a917a12d5c5909e901"
@@ -3119,13 +3112,13 @@ electron-updater@^4.6:
     lodash.isequal "^4.5.0"
     semver "^7.3.5"
 
-electron@39.2.7:
-  version "39.2.7"
-  resolved "https://registry.yarnpkg.com/electron/-/electron-39.2.7.tgz#1cf2371304994fe26c564764bd50878fe405fb4b"
-  integrity sha512-KU0uFS6LSTh4aOIC3miolcbizOFP7N1M46VTYVfqIgFiuA2ilfNaOHLDS9tCMvwwHRowAsvqBrh9NgMXcTOHCQ==
+electron@29.2.0:
+  version "29.2.0"
+  resolved "https://registry.npmjs.org/electron/-/electron-29.2.0.tgz"
+  integrity sha512-ALKrCN52RG4g9prx4DriXSPnY5WoiyRUCNp7zEVQuoiNOpHTNqMMpRidQAHzntV4hajF1LMWHVoBkwqIs1jHhg==
   dependencies:
     "@electron/get" "^2.0.0"
-    "@types/node" "^22.7.7"
+    "@types/node" "^20.9.0"
     extract-zip "^2.0.1"
 
 emoji-regex@^8.0.0:
@@ -8002,11 +7995,6 @@ undici-types@~5.26.4:
   resolved "https://registry.npmjs.org/undici-types/-/undici-types-5.26.5.tgz"
   integrity sha512-JlCMO+ehdEIKqlFxk6IfVoAUVmgz7cU7zD/h9XZ0qzeosSHmUJVOzSQvvYSYWXkFXC+IfLKSIffhv0sVZup6pA==
 
-undici-types@~6.21.0:
-  version "6.21.0"
-  resolved "https://registry.yarnpkg.com/undici-types/-/undici-types-6.21.0.tgz#691d00af3909be93a7faa13be61b3a5b50ef12cb"
-  integrity sha512-iwDZqg0QAGrg9Rav5H4n0M64c3mkR59cJ6wQp+7C4nI0gsmExaedaYLNO44eT4AtBBwjbTiGPMlt2Md0T9H9JQ==
-
 undici-types@~7.16.0:
   version "7.16.0"
   resolved "https://registry.yarnpkg.com/undici-types/-/undici-types-7.16.0.tgz#ffccdff36aea4884cbfce9a750a0580224f58a46"