Michel2/pybricks-api
1
0
Fork 0
mirror of https://github.com/pybricks/pybricks-api.git synced 2026-09-12 01:24:17 +00:00
Code Issues Releases Activity

pybricks.common.BLE: Improve typing for hub constructor.

Browse Source 
Update type hint for broadcast_channel to Optional, as None is allowed.
This commit is contained in:
Frederik Leonhardt
2026-05-28 11:12:17 +02:00
committed by Laurens Valk
parent 3bc2f35e3e
commit 7411a246c9
2 changed files with 23 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
jedi/tests/test_get_signature.py
+15 -5
View File
@@ -86,12 +86,22 @@ CONSTRUCTOR_PARAMS = [
pytest.param(
"pybricks.hubs",
"MoveHub",
[["broadcast_channel: int=None", "observe_channels: Sequence[int]=[]"]],
[
[
"broadcast_channel: Optional[int]=None",
"observe_channels: Sequence[int]=[]",
]
],
),
pytest.param(
"pybricks.hubs",
"CityHub",
[["broadcast_channel: int=None", "observe_channels: Sequence[int]=[]"]],
[
[
"broadcast_channel: Optional[int]=None",
"observe_channels: Sequence[int]=[]",
]
],
),
pytest.param(
"pybricks.hubs",
@@ -100,7 +110,7 @@ CONSTRUCTOR_PARAMS = [
[
"top_side: Axis=Axis.Z",
"front_side: Axis=Axis.X",
"broadcast_channel: int=None",
"broadcast_channel: Optional[int]=None",
"observe_channels: Sequence[int]=[]",
]
],
@@ -112,7 +122,7 @@ CONSTRUCTOR_PARAMS = [
[
"top_side: Axis=Axis.Z",
"front_side: Axis=Axis.X",
"broadcast_channel: int=None",
"broadcast_channel: Optional[int]=None",
"observe_channels: Sequence[int]=[]",
]
],
@@ -124,7 +134,7 @@ CONSTRUCTOR_PARAMS = [
[
"top_side: Axis=Axis.Z",
"front_side: Axis=Axis.X",
"broadcast_channel: int=None",
"broadcast_channel: Optional[int]=None",
"observe_channels: Sequence[int]=[]",
]
],
src/pybricks/hubs.py
+8 -6
View File
@@ -3,7 +3,7 @@
"""LEGO® Programmable Hubs."""
from typing import Sequence
from typing import Sequence, Optional
from . import _common
from .ev3dev import _speaker
@@ -44,7 +44,9 @@ class MoveHub:
ble = _common.BLE()
def __init__(
self, broadcast_channel: int = None, observe_channels: Sequence[int] = []
self,
broadcast_channel: Optional[int] = None,
observe_channels: Sequence[int] = [],
):
"""MoveHub(top_side=Axis.Z, front_side=Axis.X, broadcast_channel=None, observe_channels=[])
@@ -78,7 +80,7 @@ class CityHub:
ble = _common.BLE()
def __init__(
self, broadcast_channel: int = None, observe_channels: Sequence[int] = []
self, broadcast_channel: Optional[int] = None, observe_channels: Sequence[int] = []
):
"""CityHub(broadcast_channel=None, observe_channels=[])
@@ -112,7 +114,7 @@ class TechnicHub:
self,
top_side: Axis = Axis.Z,
front_side: Axis = Axis.X,
broadcast_channel: int = None,
broadcast_channel: Optional[int] = None,
observe_channels: Sequence[int] = [],
):
"""TechnicHub(top_side=Axis.Z, front_side=Axis.X, broadcast_channel=None, observe_channels=[])
@@ -157,7 +159,7 @@ class EssentialHub:
self,
top_side: Axis = Axis.Z,
front_side: Axis = Axis.X,
broadcast_channel: int = None,
broadcast_channel: Optional[int] = None,
observe_channels: Sequence[int] = [],
):
"""EssentialHub(top_side=Axis.Z, front_side=Axis.X, broadcast_channel=None, observe_channels=[])
@@ -212,7 +214,7 @@ class PrimeHub:
self,
top_side: Axis = Axis.Z,
front_side: Axis = Axis.X,
broadcast_channel: int = None,
broadcast_channel: Optional[int] = None,
observe_channels: Sequence[int] = [],
):
"""PrimeHub(top_side=Axis.Z, front_side=Axis.X, broadcast_channel=None, observe_channels=[])