Michel2/pybricks-code
1
0
Fork 0
mirror of https://github.com/pybricks/pybricks-code.git synced 2026-09-12 09:36:27 +00:00
Code Issues Releases Activity

ble/sagas: spawn ble writes

Browse Source 
Code depends on always receiving a didWrite/didFailToWrite, however
when a hub disconnected, these tasks were being cancelled. Spawning
protects them from cancellation.
This commit is contained in:
David Lechner
2023-04-01 15:17:22 -05:00
committed by David Lechner
parent c8e7e86da0
commit 1e764b4e95
1 changed files with 18 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ble/sagas.ts
+18 -12
View File
@@ -82,12 +82,15 @@ function* handleWriteCommand(
char: BluetoothRemoteGATTCharacteristic,
action: ReturnType<typeof writeCommand>,
): Generator {
try {
yield* call(() => char.writeValueWithResponse(action.value.buffer));
yield* put(didWriteCommand(action.id));
} catch (err) {
yield* put(didFailToWriteCommand(action.id, ensureError(err)));
}
// have to spawn to avoid cancellation
yield* spawn(function* () {
try {
yield* call(() => char.writeValueWithResponse(action.value.buffer));
yield* put(didWriteCommand(action.id));
} catch (err) {
yield* put(didFailToWriteCommand(action.id, ensureError(err)));
}
});
}
function* handleUartValueChanged(data: DataView): Generator {
@@ -98,12 +101,15 @@ function* handleWriteUart(
char: BluetoothRemoteGATTCharacteristic,
action: ReturnType<typeof writeUart>,
): Generator {
try {
yield* call(() => char.writeValueWithoutResponse(action.value.buffer));
yield* put(didWriteUart(action.id));
} catch (err) {
yield* put(didFailToWriteUart(action.id, ensureError(err)));
}
// have to spawn to avoid cancellation
yield* spawn(function* () {
try {
yield* call(() => char.writeValueWithoutResponse(action.value.buffer));
yield* put(didWriteUart(action.id));
} catch (err) {
yield* put(didFailToWriteUart(action.id, ensureError(err)));
}
});
}
function* handleBleConnectPybricks(): Generator {