Michel2/pybricks-code
1
0
Fork 0
mirror of https://github.com/pybricks/pybricks-code.git synced 2026-09-15 02:54:07 +00:00
Code Issues Releases Activity

alerts/UnexpectedErrorAlert: fix not showing message

Browse Source 
This was not showing the actual error message.

Also hide the technical details when no stack trace is available.
This commit is contained in:
David Lechner
2022-10-21 16:26:43 -05:00
parent 49cc0e2126
commit 4400c0663e
1 changed files with 19 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/alerts/UnexpectedErrorAlert.tsx
+19 -14
View File
@@ -28,20 +28,25 @@ const UnexpectedErrorAlert: React.VoidFunctionComponent<UnexpectedErrorAlertProp
return (
<>
<p>{i18n.translate('message', { errorMessage: error.message })}</p>
<span>
<Button
aria-labelledby={labelId}
minimal={true}
small={true}
icon={isExpanded ? 'chevron-down' : 'chevron-right'}
onClick={() => setIsExpanded((v) => !v)}
/>
<span id={labelId}>{i18n.translate('technicalInfo')}</span>
</span>
<Collapse isOpen={isExpanded}>
<Pre className="pb-alerts-stack-trace">{error.stack}</Pre>
</Collapse>
<p>{i18n.translate('message')}</p>
<p>{error.message}</p>
{error.stack && (
<>
<span>
<Button
aria-labelledby={labelId}
minimal={true}
small={true}
icon={isExpanded ? 'chevron-down' : 'chevron-right'}
onClick={() => setIsExpanded((v) => !v)}
/>
<span id={labelId}>{i18n.translate('technicalInfo')}</span>
</span>
<Collapse isOpen={isExpanded}>
<Pre className="pb-alerts-stack-trace">{error.stack}</Pre>
</Collapse>
</>
)}
<div>
<ButtonGroup minimal={true} fill={true}>
<Button