Michel2/pybricks-code
1
0
Fork 0
mirror of https://github.com/pybricks/pybricks-code.git synced 2026-09-14 10:35:11 +00:00
Code Issues Releases Activity

hub/reducers: Also match legacy flags against USB actions.

Browse Source 
We were already doing something similar for USB firmware revision, but this was missed for software revision.
This commit is contained in:
Laurens Valk
2026-03-19 10:08:42 +01:00
parent f3dc7b55b7
commit 660a796333
1 changed files with 14 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/hub/reducers.ts
+14 -4
View File
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: MIT
// Copyright (c) 2020-2025 The Pybricks Authors
// Copyright (c) 2020-2026 The Pybricks Authors
import { Reducer, combineReducers } from 'redux';
import * as semver from 'semver';
@@ -31,6 +31,7 @@ import {
usbDidDisconnectPybricks,
usbDidReceiveDeviceName,
usbDidReceiveFirmwareRevision,
usbDidReceiveSoftwareRevision,
usbDisconnectPybricks,
} from '../usb/actions';
import { pythonVersionToSemver } from '../utils/version';
@@ -361,7 +362,10 @@ const useLegacyDownload: Reducer<boolean> = (state = false, action) => {
* When true, use NUS for stdio instead of Pybricks control characteristic.
*/
const useLegacyStdio: Reducer<boolean> = (state = false, action) => {
if (bleDIServiceDidReceiveSoftwareRevision.matches(action)) {
if (
bleDIServiceDidReceiveSoftwareRevision.matches(action) ||
usbDidReceiveSoftwareRevision.matches(action)
) {
// Behavior changed starting with Pybricks Profile v1.3.0.
return !semver.satisfies(action.version, '^1.3.0');
}
@@ -373,7 +377,10 @@ const useLegacyStdio: Reducer<boolean> = (state = false, action) => {
* When true, use Legacy StartUserProgram.
*/
const useLegacyStartUserProgram: Reducer<boolean> = (state = false, action) => {
if (bleDIServiceDidReceiveSoftwareRevision.matches(action)) {
if (
bleDIServiceDidReceiveSoftwareRevision.matches(action) ||
usbDidReceiveSoftwareRevision.matches(action)
) {
// Behavior changed starting with Pybricks Profile v1.4.0.
return !semver.satisfies(action.version, '^1.4.0');
}
@@ -385,7 +392,10 @@ const useLegacyStartUserProgram: Reducer<boolean> = (state = false, action) => {
* When true, use the legacy `__main__` module name instead of the actual file name.
*/
const useLegacyMainModule: Reducer<boolean> = (state = false, action) => {
if (bleDIServiceDidReceiveSoftwareRevision.matches(action)) {
if (
bleDIServiceDidReceiveSoftwareRevision.matches(action) ||
usbDidReceiveSoftwareRevision.matches(action)
) {
// Behavior changed starting with Pybricks Profile v1.5.0.
return !semver.satisfies(action.version, '^1.5.0');
}