Michel2/pybricks-code
1
0
Fork 0
mirror of https://github.com/pybricks/pybricks-code.git synced 2026-07-27 19:57:11 +00:00
Code Issues Releases Activity

firmware: remove android check for chunk size

Browse Source 
This should no longer be needed since Chrome v98 (released Nov. 2021).
This commit is contained in:
David Lechner
2022-12-06 15:50:35 -06:00
parent cc20ab8c35
commit 6687bb73ce
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
CHANGELOG.md
+4 -2
View File
@@ -9,9 +9,11 @@
### Fixed
- Fixed first tour item not shown if settings is not open ([support#823]).
- Fixed selected activity tab not controlled independently per window ([support#807]);
- Fixed selected documentation visibility not controlled independently per window ([support#807]);
- Fixed selected activity tab not controlled independently per window ([support#807]).
- Fixed selected documentation visibility not controlled independently per window ([support#807]).
- Fixed slow firmware flash on Android ([support#438]).
[support#438]: https://github.com/pybricks/support/issues/438
[support#778]: https://github.com/pybricks/support/issues/778
[support#807]: https://github.com/pybricks/support/issues/807
[support#823]: https://github.com/pybricks/support/issues/823
src/firmware/sagas.ts
+2 -4
View File
@@ -63,7 +63,6 @@ import { RootState } from '../reducers';
import { LegoUsbProductId, legoUsbVendorId } from '../usb';
import { defined, ensureError, hex, maybe } from '../utils';
import { crc32, fmod, sumComplement32 } from '../utils/math';
import { isAndroid } from '../utils/os';
import {
FailToFinishReasonType,
HubError,
@@ -485,9 +484,8 @@ function* handleFlashFirmware(action: ReturnType<typeof flashFirmware>): Generat
yield* disconnectAndCancel();
}
// 14 is "safe" size for all hubs and Android
const maxDataSize =
(!isAndroid() && MaxProgramFlashSize.get(info.hubType)) || 14;
// 14 is "safe" size for all hubs
const maxDataSize = MaxProgramFlashSize.get(info.hubType) || 14;
let runningChecksum = 0xff;