Michel2/pybricks-code
1
0
Fork 0
mirror of https://github.com/pybricks/pybricks-code.git synced 2026-09-12 01:23:52 +00:00
Code Issues Releases Activity
1,279 Commits 12 Branches 59 Tags
df6e93407e4ef549071ca0698fd2811c7f872c2d
Commit Graph
1279 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
David Lechner df6e93407e terminal: remove questionable tabindex 
Not sure if this has a purpose I don't know about but removing it gives
better behavior when using keyboard navigation.
 2022-05-18 10:13:31 -05:00
David Lechner 0839392183 rework roving tab index to use react-aria 2022-05-17 23:20:09 -05:00
David Lechner f7dcf8b0f7 components/toolbar: move from utils 
This is a better home.
 2022-05-17 11:28:21 -05:00
David Lechner ef7f6d15c4 improve focus styles 2022-05-16 21:59:58 -05:00
David Lechner 9e092ca469 explorer: fix tree item button translations not updating 2022-05-16 01:11:10 -05:00
David Lechner 8ba4d49e3b components: add new component to fix a11y issues 2022-05-15 23:27:55 -05:00
David Lechner b729d90907 yarn: add patch for react-dev-utils 
https://github.com/facebook/create-react-app/pull/11878
 2022-05-14 14:18:49 -05:00
David Lechner 728e7c3b26 settings: change tooltips to help buttons 
This is more friendly for touch screen users.
 2022-05-14 11:09:41 -05:00
David Lechner fb681e06ec explorer/fileNameFormGroup: hide tag 
screen readers don't need to read the file extension tag
 2022-05-13 23:52:21 -05:00
David Lechner 404818bcdf toolbar: use roving focus 2022-05-13 23:28:12 -05:00
David Lechner f0dcb281de utils: add Toolbar component 
This adds a generic toolbar component that follow aria guidelines.
 2022-05-13 22:36:01 -05:00
David Lechner a185457067 explorer: don't disable archive button 
disabled buttons are bad for accessability
 2022-05-13 16:48:32 -05:00
David Lechner dc2daf2fe4 toolbar: hide icons from a11y tools 
There are already ARIA labels, so the icons should be hidden.
 2022-05-13 14:44:26 -05:00
David Lechner 7322c9d667 utils: drop pointerEventsNone 
Not sure why this was used in the first place, but causes non-default
behavior which can be confusing.
 2022-05-13 14:39:35 -05:00
David Lechner cd88789be7 toolbar: override aria-haspopup 
The Tooltip2 component incorrectly sets this attribute which should
not be set for tooltips.
 2022-05-13 14:38:12 -05:00
David Lechner a0f8b9a0ca more style and a11y fixes 2022-05-12 20:46:50 -05:00
David Lechner 3fb98e6ae1 ViewHeightSensor: hard-code style 
This style is not about looks, so hard-code it instead of using style sheets.
 2022-05-12 19:23:49 -05:00
David Lechner 5dc6b2e4cb util: drop preventBrowserNativeContextMenu 
This is done once at the top-level app, so is no longer needed.
 2022-05-12 19:20:46 -05:00
David Lechner 6816795c6d activities: use blueprintjs tabs for keyboard a18y 2022-05-12 19:17:09 -05:00
David Lechner fa0a9a109c editor: improve a18y and visual appearance 2022-05-12 16:14:48 -05:00
David Lechner edd8ebfd64 Add Activities 
This adds a new Activities tab list and view similar to VS code. The
Explorer and Settings are migrated to this view.
 2022-05-12 12:33:21 -05:00
David Lechner 65623f801d update for breaking blueprintjs style changes 
it is no longer feasible to build the blueprintjs css ourselves, so we
just use all of the default variable values and override things using
selectors instead.
 2022-05-11 18:13:36 -05:00
David Lechner 896b3eae3e update monoco editor 2022-05-10 22:20:21 -05:00
David Lechner 8d522b963a update blueprints 
This had a breaking change with regard to sass compiling.
 2022-05-10 22:15:28 -05:00
David Lechner 96d36f81e2 eslint: ignore scripts/* 
These were automatically generated, so leave them be.
 2022-05-10 20:55:04 -05:00
David Lechner df12c40802 drop craco 
Since we aren't using react-scripts any more, craco doesn't do anything.
This merges the craco config into the config created by `yarn eject`.
 2022-05-10 20:27:58 -05:00
David Lechner 5ee74187eb optimize svgs 
The new webpack doesn't like the xml namespaces and refuses to compile
so we have to save the svg files in optimized form.
 2022-05-10 20:26:58 -05:00
David Lechner 10a3efc41f yarn eject 2022-05-10 17:52:37 -05:00
David Lechner 54e826490d yarn up react-scripts 
This doesn't compile due to breaking changes, but we have to commit
before ejecting.
 2022-05-10 17:46:48 -05:00
David Lechner 8ffaf64292 fileStorage: add file create option 
When opening a file, sometimes we want to create it if it does not
exist and sometimes we don't.
 2022-04-08 18:29:05 -05:00
David Lechner e0a6926d01 explorer: implement duplicate file feature 2022-04-08 18:11:09 -05:00
David Lechner 30741b13ef explorer: drop rename feature 
It turns out that renaming files while they are open is technically
difficult problem. We will forgo this feature for now.
 2022-04-08 14:30:21 -05:00
David Lechner d238e68deb explorer: new delete alert dialog 
This replaces the delete notification with a new alert dialog. This
makes for better keyboard interaction and forces the user to make a
decision before doing anything else.

Also fixes closing the editor before deleting the file.
 2022-04-08 12:53:12 -05:00
David Lechner 1c30683b93 explorer: fix wrong file names 2022-04-08 11:58:13 -05:00
David Lechner 825607952f newFileWizard: doc comments 2022-04-08 11:22:46 -05:00
David Lechner 2536e17865 explorer: fix click propagating from action buttons 
When the tree item actions buttons were clicked, they were also clicking
the underlying tree item.
 2022-04-08 11:04:39 -05:00
David Lechner fad7b0114a explorer/newFileWizard: refactor 
This refactors the new file wizard to be more independent. Most of the
control is now done through the saga instead of splitting it between
react and the sagas.

Also fix a few issues while we are touching this:
- pressing enter now accepts the dialog
- newly created file is now activated in the editor
 2022-04-08 10:52:54 -05:00
David Lechner 8ac77560fb editor: add tabs for controlling open/active files 2022-04-07 21:17:09 -05:00
David Lechner 56858390ca notifications: allow viewing stack trace of unexpected error 
Previously, it was only possible to view the stack trace by clicking
the copy button and pasting it somewhere.
 2022-04-07 11:24:07 -05:00
David Lechner c29ca56658 utils: fix defined() 
NonNullable means both not undefined and not null.
 2022-04-06 18:16:21 -05:00
David Lechner 158e8f2693 fix typo 2022-04-06 09:01:14 -05:00
David Lechner da7e983ad2 yarn: drop navigator.locks patch 
The fix was merged upstream.
 2022-04-05 18:52:59 -05:00
David Lechner 89a2019a98 explorer: add action for activating file 
this simply forwards the action to the editor module
 2022-04-05 18:10:06 -05:00
David Lechner 48bc6dbe4d explorer: sort actions 
the rename actions were not grouped all together
 2022-04-05 17:46:05 -05:00
David Lechner 76eade2038 index: drop react-complex-tree css 
since we are using a custom renderer, we are not using any of this css.
 2022-04-05 17:33:24 -05:00
David Lechner 626dc82b6b tree-renderer: better workaround for focus manager 
Changing the focus manager at runtime doesn't work as expected, so we
work around with a css hack instead.
 2022-04-05 17:31:47 -05:00
David Lechner 6289f1df92 utils/tree-renderer: do not make icon focusable 2022-04-05 11:13:42 -05:00
David Lechner 6e55be056c explorer/reducers: don't use FileMetadata 
This separates the explorer files state from the fileStorage FileMetadata.
The latter contains extra info that the explorer doesn't need. This
will prevent rerendering each time the file contents change.
 2022-04-05 10:52:11 -05:00
David Lechner c6cf0608f4 explorer: move files state from fileStorage 
This state should be exclusivly used to for displaying files in the
explorer, so the state should be in the explorer branch of the
reducer tree.
 2022-04-04 18:59:13 -05:00
David Lechner 05731e50fc explorer: split archive saga from fileStorage 
This splits the fileStorage archive into two sagas to separate concerns.
fileStorage now just gives a dump of the database and explorer deals
with the user interaction and zipping.
 2022-04-04 17:48:36 -05:00