mirror of
https://github.com/thomasnordquist/MQTT-Explorer.git
synced 2026-09-12 09:35:01 +00:00
Address code review feedback - add clarifying comments
- Add comment explaining TEST_STATUS outcome values - Improve error message specificity in generateMarkdownSummary.js Co-authored-by: thomasnordquist <7721625+thomasnordquist@users.noreply.github.com>
This commit is contained in:
co-authored by
thomasnordquist
parent
e338ab9ccf
commit
0dabd89ef2
@@ -150,6 +150,7 @@ jobs:
|
||||
id: markdown
|
||||
env:
|
||||
BASE_URL: ${{ steps.fileurl.outputs.base-url }}
|
||||
# Outcome can be: 'success', 'failure', 'cancelled', or 'skipped'
|
||||
TEST_STATUS: ${{ steps.generate_video.outcome }}
|
||||
run: |
|
||||
MARKDOWN=$(node ./scripts/generateMarkdownSummary.js "${BASE_URL}" "${TEST_STATUS}")
|
||||
|
||||
@@ -17,7 +17,7 @@ try {
|
||||
scenes = JSON.parse(fs.readFileSync('scenes.json', 'utf8'));
|
||||
}
|
||||
} catch (error) {
|
||||
console.error('Warning: Could not read scenes.json:', error.message);
|
||||
console.error('Warning: Could not read scenes.json - video segments will not be available:', error.message);
|
||||
}
|
||||
|
||||
// Sanitize scene name to prevent path traversal
|
||||
|
||||
Reference in New Issue
Block a user