Michel2/pybricks-code
1
0
Fork 0
mirror of https://github.com/pybricks/pybricks-code.git synced 2026-09-14 18:46:17 +00:00
Code Issues Releases Activity

firmware/sagas: fix duplicate error alerts for ev3 flashing

Browse Source 
Remove alertsShowAlert() calls. didFailToFinish() already triggers
an error toast.
This commit is contained in:
David Lechner
2026-01-04 17:27:08 -06:00
parent 71a6727a8f
commit 6911bdd3da
1 changed files with 0 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/firmware/sagas.ts
-10
View File
@@ -1230,11 +1230,6 @@ function* handleFlashEV3(action: ReturnType<typeof firmwareFlashEV3>): Generator
);
if (eraseError) {
yield* put(
alertsShowAlert('alerts', 'unexpectedError', {
error: eraseError,
}),
);
yield* put(alertsHideAlert(firmwareEv3ProgressToastId));
// FIXME: should have a better error reason
yield* put(didFailToFinish(FailToFinishReasonType.Unknown, eraseError));
@@ -1248,11 +1243,6 @@ function* handleFlashEV3(action: ReturnType<typeof firmwareFlashEV3>): Generator
const [, sendError] = yield* sendCommand(0xf2, new Uint8Array(payload));
if (sendError) {
yield* put(
alertsShowAlert('alerts', 'unexpectedError', {
error: sendError,
}),
);
yield* put(alertsHideAlert(firmwareEv3ProgressToastId));
// FIXME: should have a better error reason
yield* put(didFailToFinish(FailToFinishReasonType.Unknown, sendError));