mirror of
https://github.com/pybricks/pybricks-code.git
synced 2026-07-28 04:08:05 +00:00
remove stickiness of toolbar to avoid breaking the layout
clicking on a link with a URI fragment (e.g. https://docs.pybricks.com/en/latest/parameters.html#pybricks.parameters.Port) inside the documentation iframe breaks the layout. The browser seems to force the parent frame to scroll to the position as well. As the toolbar is fixed, the rest of the content is scrolled under it. Rerendering after the link click fixes the layout (at least if done manually). But a more elegant solutions is to remove the absolute positioning of the toolbar. It is not really necessary to pin it, as the rest of the layout always spans over the complete width and height of the browser window.
This commit is contained in:
@@ -18,7 +18,6 @@ class Toolbar extends React.Component {
|
||||
return (
|
||||
<Navbar
|
||||
onContextMenu={(e): void => e.preventDefault()}
|
||||
fixedToTop={true}
|
||||
className="no-box-shadow"
|
||||
>
|
||||
<Navbar.Group>
|
||||
|
||||
@@ -28,8 +28,6 @@ $status-bar-height: 3vh;
|
||||
body {
|
||||
// no scrolling of the page
|
||||
overflow: hidden;
|
||||
// See https://blueprintjs.com/docs/#core/components/navbar
|
||||
padding-top: $pt-navbar-height;
|
||||
}
|
||||
|
||||
// Utility classes
|
||||
|
||||
Reference in New Issue
Block a user